Date: Wed, 10 Jun 2009 18:27:15 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c tcp_var.h Message-ID: <200906101827.n5AIRPKa040678@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2009-06-10 18:27:15 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_usrreq.c tcp_var.h
Log:
SVN rev 193941 on 2009-06-10 18:27:15Z by jhb
Change a few members of tcpcb that store cached copies of ticks to be ints
instead of unsigned longs. This fixes a few overflow edge cases on 64-bit
platforms. Specifically, if an idle connection receives a packet shortly
before 2^31 clock ticks of uptime (about 25 days with hz=1000) and the keep
alive timer fires after 2^31 clock ticks, the keep alive timer will think
that the connection has been idle for a very long time and will immediately
drop the connection instead of sending a keep alive probe.
Reviewed by: silby, gnn, lstewart
MFC after: 1 week
Revision Changes Path
1.404 +1 -1 src/sys/netinet/tcp_input.c
1.186 +3 -3 src/sys/netinet/tcp_usrreq.c
1.176 +4 -4 src/sys/netinet/tcp_var.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906101827.n5AIRPKa040678>