Date: Thu, 25 Aug 2022 02:26:13 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 05c9a0158f68 - main - libc: Add strverscmp(3) and versionsort(3) Message-ID: <48508922-8A39-424C-9CD6-1DE56EF0AA13@freebsd.org> In-Reply-To: <YwbO8Na3k0BpvWmn@kib.kiev.ua> References: <202208250029.27P0TRwK091769@gitrepo.freebsd.org> <FFCE6298-AF3B-4B50-B1C1-B4E01F604B30@freebsd.org> <YwbO8Na3k0BpvWmn@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Aug 2022, at 02:22, Konstantin Belousov <kostikbel@gmail.com> = wrote: >=20 > On Thu, Aug 25, 2022 at 02:07:12AM +0100, Jessica Clarke wrote: >> On 25 Aug 2022, at 01:29, Konstantin Belousov <kib@FreeBSD.org> = wrote: >>> + const unsigned char *u1 =3D __DECONST(const unsigned char *, = s1); >>> + const unsigned char *u2 =3D __DECONST(const unsigned char *, = s2); >>=20 >> Why is __DECONST needed? Casting from const char * to const unsigned >> char * should never warn, surely? >=20 > I requested the use of __DECONST there. Nobody knows what would be = next > trend in the C language breaking among compiler writers. We guarantee > that __DECONST() is adopted to whatever warnings are added. This is not good justification to do so. Sprinkling unnecessary __DECONST throughout the code base makes it harder to figure out = what=E2=80=99s actually going on as you have to figure out if the __DECONST is actually doing something interesting or there out of paranoia. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48508922-8A39-424C-9CD6-1DE56EF0AA13>