Date: Thu, 22 Apr 2004 23:33:50 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: marcel@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 51597 for review Message-ID: <20040422.233350.119859738.imp@bsdimp.com> In-Reply-To: <200404230321.i3N3LxhW010292@repoman.freebsd.org> References: <200404230321.i3N3LxhW010292@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200404230321.i3N3LxhW010292@repoman.freebsd.org>
Marcel Moolenaar <marcel@freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=51597
:
: Change 51597 by marcel@marcel_nfs on 2004/04/22 20:21:30
:
: Provide a stopgap fix for the sparc64 ebus breakage
: due to the PCI mega-commit. Soon to appear in a CVS
: repository near you.
:
: Affected files ...
:
: .. //depot/projects/gdb/sys/dev/pci/pci.c#7 edit
:
: Differences ...
:
: ==== //depot/projects/gdb/sys/dev/pci/pci.c#7 (text+ko) ====
:
: @@ -825,6 +825,12 @@
: if (base == 0)
: return 1;
:
: + /* Sun EBus bridges contain the ranges for the devices beyond them */
: + if ((pci_get_class(dev) == PCIC_BRIDGE) &&
: + (pci_get_vendor(dev) == 0x108e) &&
: + (pci_get_device(dev) == 0x1000 || pci_get_device(dev) == 0x1100))
: + return 1;
: +
: start = base;
: end = base + (1 << ln2size) - 1;
: count = 1 << ln2size;
Shouldn't the ebus bridge device be allocating the resources and
giving them to their children? This isn't the right fix and I'd like
to work with you to the fix at the right level...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040422.233350.119859738.imp>