Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Oct 2015 10:58:42 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        NGie Cooper <yaneurabeya@gmail.com>
Cc:        jenkins-admin@FreeBSD.org, ngie@FreeBSD.org, freebsd-current@FreeBSD.org
Subject:   Re: FreeBSD_HEAD_amd64_gcc4.9 - Build #673 - Failure
Message-ID:  <56228C52.6000200@FreeBSD.org>
In-Reply-To: <56228156.9070902@FreeBSD.org>
References:  <1743862498.27.1445058611319.JavaMail.jenkins@jenkins-9.freebsd.org> <5621D9F1.9080707@FreeBSD.org> <5621DDB1.8020807@FreeBSD.org> <31F4FEC4-B677-4EA1-BD67-F2DC458A99E4@gmail.com> <2B9A4B89-6D0D-4549-B249-FB30A8117DDF@gmail.com> <78883694-7B54-4AC3-9B5B-D715D5DA1F88@gmail.com> <56226FDB.70800@FreeBSD.org> <56227093.4020005@FreeBSD.org> <56228156.9070902@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--k0OT0Gh41pQhwVromxdNDkcLcclSPgaQC
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 10/17/2015 10:11 AM, Bryan Drewery wrote:
> On 10/17/2015 9:00 AM, Bryan Drewery wrote:
>> On 10/17/2015 8:57 AM, Bryan Drewery wrote:
>>>> Guess what happens when I use a proper clang-tblgen?
>>>>
>>>> $ make all
>>>> /usr/obj/home/ngie/git/freebsd/src/usr.bin/clang/clang-tblgen/clang-=
tblgen -gen-arm-neon  -d arm_neon.d -o arm_neon.h  /home/ngie/git/freebsd=
/src/lib/clang/include/../../../contrib/llvm/tools/clang/include/clang/Ba=
sic/arm_neon.td
>>>> $
>>>>
>>>> Voila.
>>>>
>>>> So this is happening because it=92s using clang-tblgen from the buil=
d host somehow, which is not able to process the .td files.
>>> Perhaps PATH got set wrong somehow. Note that the build log does not
>>> have an absolute path for clang-tblgen, as the above code would cause=
=2E
>>> It is just using the default PATH as other builds do.
>>
>> I reproduced this PATH issue here locally and digging deeper.
>>
>=20
> Yes, something in my changes definitely is passing the wrong PATH here.=

>=20

I figured it out.

I've been working on cleaning up bsd.subdir.mk for usage with 'includes'
because it currently uses a hack that runs sub-makes itself for
'buildincludes' and 'installincludes' (see r289282 which was reverted
but I have a working version now).

The older, duplicated bsd.subdir.mk logic, for calling 'includes' was
being executed in each subdir directly, meaning 'cd lib && make
includes' became 'cd lib && make buildincludes && make installincludes'.
 Now that the bsd.subdir.mk logic is used it is doing 'make includes',
which becomes 'make buildincludes && make installincludes' from the
top-level which pulls in the PATH=3D<default path> from /Makefile.

This of course impacts all of the targets I changed. I'll have a fix
committed shortly.

--=20
Regards,
Bryan Drewery


--k0OT0Gh41pQhwVromxdNDkcLcclSPgaQC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJWIoxSAAoJEDXXcbtuRpfP1/4H+gOcv9d02MN3bsq0xhlrddpz
yswYH5hQL/96lVMaCup6jRunGmcArfB2uZBaVZCFyzjnHDLEzjfBSd9klOTDqAL9
uWvQ4Kfqzdc3pO8kPhu/QLFOot1zUI0CLf9LTYqsCwQm8VKUbD5ePP+yyS86Ja6z
ZEHm2vnX+zJZYl/3vOxNLPM4Xs6B+xTs+sNjLUa64eNHz4HdPKVVujDIzNdITXbC
7duF4FGmqFzUL2bw5bY+RVkkEM2GE0+8GoC2HknpaOrQ1tKCQRB8rbxFNssDAZlL
uqQ+g0+PD49khkkBYipJNwPURTn3sKITJXQWeUuWg0NrOzYTaTnzD0M3BwxVvN0=
=QU+5
-----END PGP SIGNATURE-----

--k0OT0Gh41pQhwVromxdNDkcLcclSPgaQC--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56228C52.6000200>