Date: Mon, 29 Jul 2024 13:18:45 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Mark Johnston <markj@freebsd.org>, Yuri Pankov <yuri@aetern.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 801c452795ac - main - man9: Really complete the removal of MD5.9 Message-ID: <CANCZdfrXg-m%2BerGy%2BKbxypaogvMUuhaqWiY7YNaimC13jxngzw@mail.gmail.com> In-Reply-To: <a177fef6-63dc-46ba-a7c4-5be5afb1c321@FreeBSD.org> References: <202407291431.46TEVQow094080@gitrepo.freebsd.org> <63334eb1-7af6-439a-89a0-ba379428c5a6@aetern.org> <ZqfFpMXKXIZUjBdX@nuc> <CANCZdfreRtEpAn8s-Zj-VsNvArmVz7hMaLwTFbZsvrtRj40PjA@mail.gmail.com> <a177fef6-63dc-46ba-a7c4-5be5afb1c321@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hey John, On Mon, Jul 29, 2024 at 11:55 AM John Baldwin <jhb@freebsd.org> wrote: > On 7/29/24 13:40, Warner Losh wrote: > > On Mon, Jul 29, 2024 at 10:39 AM Mark Johnston <markj@freebsd.org> > wrote: > > > >> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote: > >>> Mark Johnston wrote: > >>>> The branch main has been updated by markj: > >>>> > >>>> URL: > >> > https://cgit.FreeBSD.org/src/commit/?id=801c452795ac441523655eb3277051b7b034becf > >>>> > >>>> commit 801c452795ac441523655eb3277051b7b034becf > >>>> Author: Mark Johnston <markj@FreeBSD.org> > >>>> AuthorDate: 2024-07-29 14:12:40 +0000 > >>>> Commit: Mark Johnston <markj@FreeBSD.org> > >>>> CommitDate: 2024-07-29 14:17:04 +0000 > >>>> > >>>> man9: Really complete the removal of MD5.9 > >>>> > >>>> Fixes: 46b0db2dbe9f ("Remove unnecessary and now inaccurate > >> kernel side manual page.") > >>>> Fixes: 36d68cb2ddd2 ("Complete the removal of the MD5 manual > page > >> from section 9.") > >>>> --- > >>>> ObsoleteFiles.inc | 2 ++ > >>>> share/man/man9/Makefile | 2 -- > >>>> 2 files changed, 2 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc > >>>> index b21778466800..01b4824e8692 100644 > >>>> --- a/ObsoleteFiles.inc > >>>> +++ b/ObsoleteFiles.inc > >>>> @@ -56,6 +56,8 @@ OLD_FILES+=usr/share/man/man9/ifaddr_byindex.9.gz > >>>> > >>>> # 20240729: remove MD5(9) > >>>> OLD_FILES+=usr/share/man/man9/MD5.9.gz > >>>> +OLD_FILES+=usr/share/man/man9/MD5Init.9 > >>>> +OLD_FILES+=usr/share/man/man9/MD5Transform.9 > >>> > >>> This really needs to be smarter, but you have to specify .gz suffix for > >>> man entries as we have compression enabled by default. > >> > >> Sigh, who knew it was so difficult to remove a man page. > >> > > > > There is a pull request being worked on that will be smarter about what's > > removed since we have compress (UFS) and uncompress (ZFS) setups > > now. > > Does it just add an OLD_MAN helper variable to use instead of OLD_FILES > and then try the various extension combinations for each OLD_MAN? > https://github.com/freebsd/freebsd-src/pull/1295 was submitted a bit ago. the repetition is why I've not committed it. Is an approach like that good, or should we move all the old man pages to OLD_MAN? Warner > -- > John Baldwin > > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">Hey John,<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 29, 2024 at 11:55 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 7/29/24 13:40, Warner Losh wrote:<br> > On Mon, Jul 29, 2024 at 10:39 AM Mark Johnston <<a href="mailto:markj@freebsd.org" target="_blank">markj@freebsd.org</a>> wrote:<br> > <br> >> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote:<br> >>> Mark Johnston wrote:<br> >>>> The branch main has been updated by markj:<br> >>>><br> >>>> URL:<br> >> <a href="https://cgit.FreeBSD.org/src/commit/?id=801c452795ac441523655eb3277051b7b034becf" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=801c452795ac441523655eb3277051b7b034becf</a><br>; >>>><br> >>>> commit 801c452795ac441523655eb3277051b7b034becf<br> >>>> Author: Mark Johnston <markj@FreeBSD.org><br> >>>> AuthorDate: 2024-07-29 14:12:40 +0000<br> >>>> Commit: Mark Johnston <markj@FreeBSD.org><br> >>>> CommitDate: 2024-07-29 14:17:04 +0000<br> >>>><br> >>>> man9: Really complete the removal of MD5.9<br> >>>><br> >>>> Fixes: 46b0db2dbe9f ("Remove unnecessary and now inaccurate<br> >> kernel side manual page.")<br> >>>> Fixes: 36d68cb2ddd2 ("Complete the removal of the MD5 manual page<br> >> from section 9.")<br> >>>> ---<br> >>>> ObsoleteFiles.inc | 2 ++<br> >>>> share/man/man9/Makefile | 2 --<br> >>>> 2 files changed, 2 insertions(+), 2 deletions(-)<br> >>>><br> >>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc<br> >>>> index b21778466800..01b4824e8692 100644<br> >>>> --- a/ObsoleteFiles.inc<br> >>>> +++ b/ObsoleteFiles.inc<br> >>>> @@ -56,6 +56,8 @@ OLD_FILES+=usr/share/man/man9/ifaddr_byindex.9.gz<br> >>>><br> >>>> # 20240729: remove MD5(9)<br> >>>> OLD_FILES+=usr/share/man/man9/MD5.9.gz<br> >>>> +OLD_FILES+=usr/share/man/man9/MD5Init.9<br> >>>> +OLD_FILES+=usr/share/man/man9/MD5Transform.9<br> >>><br> >>> This really needs to be smarter, but you have to specify .gz suffix for<br> >>> man entries as we have compression enabled by default.<br> >><br> >> Sigh, who knew it was so difficult to remove a man page.<br> >><br> > <br> > There is a pull request being worked on that will be smarter about what's<br> > removed since we have compress (UFS) and uncompress (ZFS) setups<br> > now.<br> <br> Does it just add an OLD_MAN helper variable to use instead of OLD_FILES<br> and then try the various extension combinations for each OLD_MAN?<br></blockquote><div><br></div><div><a href="https://github.com/freebsd/freebsd-src/pull/1295">https://github.com/freebsd/freebsd-src/pull/1295</a><br></div><div><br></div><div>was submitted a bit ago. the repetition is why I've not committed it. Is an approach</div><div>like that good, or should we move all the old man pages to OLD_MAN?</div><div><br></div><div>Warner</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> -- <br> John Baldwin<br> <br> </blockquote></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrXg-m%2BerGy%2BKbxypaogvMUuhaqWiY7YNaimC13jxngzw>