Date: Thu, 23 Oct 2003 15:37:49 +0200 From: Thomas Quinot <thomas@FreeBSD.ORG> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: freebsd-scsi@freebsd.org Subject: Re: [src] cvs commit: src/sys/cam cam_periph.c Message-ID: <20031023133748.GA33994@melusine.cuivre.fr.eu.org> In-Reply-To: <20031018110146.1073816A4DF@hub.freebsd.org> References: <20031018110146.1073816A4DF@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
* Poul-Henning Kamp, 2003-10-18 :
> There is no need to muck about with the B_PHYS flag here. We never even
> get close to DEV_STRATEGY() which is the only place it is relevant.
>
> Revision Changes Path
> 1.54 +0 -8 src/sys/cam/cam_periph.c
I'm afraid this change is wrong.
> - /* set the flags */
> - mapinfo->bp[i]->b_flags = B_PHYS;
> -
12 lines below that point, we call vmapbuf(mapinfo->bp[i]),
which will panic if B_PHYS is not set. Please consider a backout.
Thomas.
--
Thomas.Quinot@Cuivre.FR.EU.ORG
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQE/l9mrAE1UuDk9JGkRAu+cAJ9w7+WWO8pg+czM/Pxb3IfsHVBALgCfaTUn
oUeggj0nvGttkXK8+LeesXo=
=U4z7
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031023133748.GA33994>