Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Jun 2017 03:25:27 +0200 (CEST)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r443793 - head/lang/gcc7-devel
Message-ID:  <alpine.LSU.2.21.1706180321130.2749@anthias.pfeifer.com>
In-Reply-To: <d1a2-9k83-wny@FreeBSD.org>
References:  <201706172327.v5HNRbGE015821@repo.freebsd.org> <d1a2-9k83-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 18 Jun 2017, Jan Beich wrote:
>>   When we set STAGE1_CXXFLAGS / CXXFLAGS in MAKE_FLAGS for arm platforms,
>>   do so incrementally (with += instead of =).
> Did you mean to use MAKE_ENV instead of +=?

I'm not sure. ;-)  In your example, += did not actually work in
the MAKE_ENV tests, did it?

Did you mean that the commit message should have referred to
MAKE_ARGS instead of MAKE_FLAGS?  If so, I agree, that was a
"typo" of mine.

If there is anything beyond that, I am not seeing it right now,
but I simply may be too tired (so a patch might be best).

Thanks,
Gerald



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1706180321130.2749>