Date: Wed, 17 Oct 2001 13:47:10 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Matt Dillon <dillon@earth.backplane.com>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/vm vnode_pager.c Message-ID: <20011017132416.E13949-100000@delplex.bde.org> In-Reply-To: <xzpr8s3ye6u.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 Oct 2001, Dag-Erling Smorgrav wrote:
> I did 'kgmon -rb ; sync ; sync ; sync ; kgmon -hpr'. The results are
> attached.
There seems to be a locking problem that obscures the real problem
(unless it is the problem). Try it without INVARIANTS or WITNESS.
> BTW, it should be possible to make profiling a normal kernel option
> (with a little help from 'makeoptions' like we do for debugging).
> It'd take a few changes to conf/{files,options} and the Makefile
> skeletons, but it would allow us to remove quite a bit of special-
> case code from config(8).
Well, it's a special option ("profile 2" in NOTES is equivalent to -pp
on the command line). This is just as convenient in config files as
"options profiling 2". There is only a little bit of special-case
code to support enabling profiling in config. There is some special-case
code for debugging to, and the extras for profiling are just a couple
of lines in lang.l and config.y to support the keyword, and 4 extra
lines in mkmakefile.c to print a bit more when profiling is enabled.
I think the printfs for both profiling and debugging can be handled
by ifdefs on PROFLEVEL and DEBUGLEVEL if they aren't already, but this
would currently increase the amount of code from one set of printfs
in config to ${N_MACHINE_ARCH} sets of conditionals in Makefile.${MACHINE}.
We should separate out the common part of Makefile.${MACHINE} before
cleaning this up.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011017132416.E13949-100000>