Date: Thu, 01 Jul 2010 19:37:14 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Tom Evans <tevans.uk@googlemail.com> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Ports doesnt respect fetch environment settings Message-ID: <86vd8zkss5.fsf@ds4.des.no> In-Reply-To: <AANLkTikrYfbaKMgruYxOlX5FJGo2NZiaVUkX3nfhuAZu@mail.gmail.com> (Tom Evans's message of "Thu, 1 Jul 2010 14:47:10 %2B0100") References: <AANLkTinn5bPXDf-tRIlpGCp3iFgtYi20mzRSbqkBcj6b@mail.gmail.com> <20100621101046.GA76036@droso.net> <AANLkTilhgzVDFX9MGQTS_DzJt_5QtlaNF--nQss-5mzj@mail.gmail.com> <20100621130743.4df77343@ernst.jennejohn.org> <AANLkTikrXvx_3Y7nkceaKSYqLQemGrIBURt1-5pwl6qr@mail.gmail.com> <AANLkTinxzijyXsAQIdf75cw-GeRH_Wd1E8zIYmU-Xlfd@mail.gmail.com> <86pqz8mkcg.fsf@ds4.des.no> <AANLkTikrYfbaKMgruYxOlX5FJGo2NZiaVUkX3nfhuAZu@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Tom Evans <tevans.uk@googlemail.com> writes: > I think this does show that the patch could be made a little better. > We only want to go through the loop one more time if we have > credentials to send, and we have credentials to send if the rv of > http_parse_authenticate is good. > > I also think the same bug would affect fetching from servers requiring > authentication, so I've made the same fix there as well. OK, I'll trust your analysis and commit this do head, then ask portmgr to do an exp run with the patch. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86vd8zkss5.fsf>