Date: Tue, 4 Apr 2023 12:49:18 +0200 From: =?UTF-8?Q?Martin_Matu=c5=a1ka?= <martin@matuska.de> To: Yuri <yuri@aetern.org>, Mateusz Guzik <mjguzik@gmail.com>, Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 643336549081 - main - If copy_file_range(2) fails with EXDEV, use fall-back. Message-ID: <80ec8122-b9c0-11e7-ae79-e51d217bd261@matuska.de> In-Reply-To: <872bff80-a306-a5b8-dbc1-cf54be85fa81@aetern.org> References: <202304040740.3347eiU8033699@gitrepo.freebsd.org> <ZCvxNeB0A0hDWa8j@FreeBSD.org> <202304040959.3349xqqB005509@critter.freebsd.dk> <ZCv1wFHCOvMEBiJG@FreeBSD.org> <202304041015.334AF7oF006042@critter.freebsd.dk> <CAGudoHEsT5-sDs9M8-w-1sPSSCWGv1Xm5HM8yAtVKFKHr9BFFA@mail.gmail.com> <872bff80-a306-a5b8-dbc1-cf54be85fa81@aetern.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I have filed this to address this issue: https://github.com/openzfs/zfs/pull/14713 It would be great if someone could review. On 4. 4. 2023 12:31, Yuri wrote: > Mateusz Guzik wrote: >> On 4/4/23, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: >>> -------- >>> Alexey Dokuchaev writes: >>> >>>> Okay, but did it leave an empty file, I wonder? >>> I didn't check, but it probably would, because cp(1) must have opened >>> and created the destination in order to call copy_file_range(2). >>> >>> PS: I'll note that EXDEV is not a documented return value from >>> copy_file_range(2), and my surprise that cp(1) did not revert >>> to the fall-back, no matter why copy_file_range(2) failed. >>> >> that's a new one and should not be happening, something is borked in >> the kernel -- cross device copies *are* supported >> >> i'll look into it later > Likely has to do with openzfs merge issues reported by Cy just above?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?80ec8122-b9c0-11e7-ae79-e51d217bd261>