Date: Mon, 24 Mar 2014 19:17:25 -0700 From: Maksim Yevmenkin <emax@freebsd.org> To: John-Mark Gurney <jmg@funkthat.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r263690 - head/sys/kern Message-ID: <CAFPOs6pNRTaKpwvVwL8_na-a6yiQLAdZvYWJ6JsFBsQ2yveNdg@mail.gmail.com> In-Reply-To: <20140324185949.GR32089@funkthat.com> References: <201403241813.s2OIDfEd024721@svn.freebsd.org> <20140324185949.GR32089@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 24, 2014 at 11:59 AM, John-Mark Gurney <jmg@funkthat.com> wrote: > Maksim Yevmenkin wrote this message on Mon, Mar 24, 2014 at 18:13 +0000: >> Author: emax >> Date: Mon Mar 24 18:13:41 2014 >> New Revision: 263690 >> URL: http://svnweb.freebsd.org/changeset/base/263690 >> >> Log: >> change defaule permissions on /dev/devstat. while i'm here remove >> D_NEEDGIANT flag > > I know that the following change is part of the remove D_NEEDGIANT, but > I'm puzzled how this code either worked before, or continues to work.. hmm... beats me too... pagelist is only growing and never shrinking, and new pages are added to the of the list, so may be that the reason, i.e. window for race is very small > It looks like pagelist was suppose to be protected by devstat_mutex, > but previously wasn't and that this is fixing that bug, is this > correct? it should fix it, yes. thanks max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFPOs6pNRTaKpwvVwL8_na-a6yiQLAdZvYWJ6JsFBsQ2yveNdg>