Date: Mon, 23 Mar 2015 01:38:45 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI <delphij@FreeBSD.org> Subject: Re: svn commit: r280308 - head/sys/fs/devfs Message-ID: <550ED3F5.6040402@FreeBSD.org> In-Reply-To: <20150321142737.GJ2379@kib.kiev.ua> References: <201503210114.t2L1ECcB075556@svn.freebsd.org> <550D5D49.6020503@FreeBSD.org> <20150321142737.GJ2379@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22/03/2015 1:27 AM, Konstantin Belousov wrote: > On Sat, Mar 21, 2015 at 11:00:09PM +1100, Kubilay Kocak wrote: >> On 21/03/2015 12:14 PM, Xin LI wrote: >>> Author: delphij >>> Date: Sat Mar 21 01:14:11 2015 >>> New Revision: 280308 >>> URL: https://svnweb.freebsd.org/changeset/base/280308 >>> >>> Log: >>> Disable timestamping on devfs read/write operations by default. >>> >>> Currently we update timestamps unconditionally when doing read or >>> write operations. This may slow things down on hardware where >>> reading timestamps is expensive (e.g. HPET, because of the default >>> vfs.timestamp_precision setting is nanosecond now) with limited >>> benefit. >>> >>> A new sysctl variable, vfs.devfs.dotimes is added, which can be >>> set to non-zero value when the old behavior is desirable. >> >> Perhaps *devfs_timestamp_update* is a better name. thoughts? >> >> If something shorter is desired: devfs_ts_update might be ok, though I >> prefer the former. >> >> Let's not forget these are user visible system control knobs, not just >> code variables, though I do understand the desire to shorten them, and >> that we do have descriptions for them ... mostly :) > > should it be > vfs.devfs.devfs_ts_devfs_ts_devfs_update_devfs > so that user is _absolutely_ sure that it is devfs related, if 'devfs' > used only one time in the MIB prevents him from realizing this ? > s/_/. devfs.timestamp_update sorry. :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?550ED3F5.6040402>