Date: Tue, 01 Feb 2022 00:03:58 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261566] Padding of DLT_PFLOG packets should be done differently Message-ID: <bug-261566-227-Scw1x0EZ3g@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-261566-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261566 --- Comment #3 from Guy Harris <gharris@sonic.net> --- > I distinctly recall looking at the Wireshark code before implementing the BPF_WORDALIGN(), however it clearly does `padded_length = WS_ROUNDUP_4(length);`, so I don't know what happened there. It got fixed from "add 3 to the length under the assumption that there's 1 byte of padding" to "round it up to a multiple of 4". (Tcpdump now does the same thing, and libpcap now gets the pflog header length from the length field, rounding it up to a multiple of 4, rather than having a hardwired length based on whatever platform it was compiled on.) > How does this look to you: That should work. -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-261566-227-Scw1x0EZ3g>