Date: Wed, 19 Jun 2002 23:21:35 -0700 From: Sean Chittenden <sean@chittenden.org> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: Kris Kennaway <kris@obsecurity.org>, walt <wsheets@sbcglobal.net>, freebsd-current <freebsd-current@FreeBSD.ORG> Subject: Re: The -current state of mozilla affairs Message-ID: <20020619232135.D37593@ninja1.internal> In-Reply-To: <1024539159.44782.21.camel@shumai.marcuscom.com>; from "marcus@marcuscom.com" on Wed, Jun 19, 2002 at = 10:12:39PM References: <3CFC588A.9070903@sbcglobal.net> <20020604134655.B62465@xor.obsecurity.org> <20020619183056.K31745@ninja1.internal> <1024539159.44782.21.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/e2eDi0V/xtL+Mc8
Content-Type: multipart/mixed; boundary="neYutvxvOLaeuPCA"
Content-Disposition: inline
--neYutvxvOLaeuPCA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
> > I supped a -CURRENT system 3 days ago and am still having the problem
> > described here, but the gcc that's in the base system is 3.1 at this
> > point. I'm installing gcc32 now and will try building this again
> > using a newer version of GCC but am not sure if this'll fix anything.
> > Anyone have any ideas/clues? -sc
>=20
> I do, but admittedly, it's not my idea. Peter Kostouros has said
> that defining THUNK_BASED_THIS_ADJUST in
> xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h fixes
> the build problem on -CURRENT. I have not tested this yet, but I
> did test a build with gcc31 from ports (per mbr@'s suggestion), and
> that works just fine.
>
> I want to test Peter's suggestion before I add more bloat to Mozilla. I
> just have a really slow -CURRENT machine. If you'd like to test the
> option, undefine CFRONT_STYLE_THIS_ADJUST, and define
> THUNK_BASED_THIS_ADJUST in the above header file, and see if it works.
Sweeet! We've got a winner. The attach patched should work but is
untested (I just brute-forced the defs earlier and am not about to
wait another 4+hrs to test this little patch). :~) Anyway, any chance
this could be committed as a patch for mozilla? -sc
--=20
Sean Chittenden
--neYutvxvOLaeuPCA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
--- xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h.orig Tue Apr 9 20:37:34 2002
+++ xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h Wed Jun 19 23:23:38 2002
@@ -94,7 +94,7 @@
* gcc is that the system gcc defines __FreeBSD_cc_version. This variable
* can also identify the period of time that 4.0-CURRENT used thunks.
*/
-#if defined(__FreeBSD_cc_version) && \
+ #if defined(__FreeBSD_cc_version) && (__FreeBSD_cc_version < 500003) && \
(__FreeBSD_cc_version < 400002 || __FreeBSD_cc_version > 400003)
#define CFRONT_STYLE_THIS_ADJUST
#else
--neYutvxvOLaeuPCA--
--/e2eDi0V/xtL+Mc8
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Comment: Sean Chittenden <sean@chittenden.org>
iD8DBQE9EXRtn09c7x7d+q0RAltpAKDTQn3AZWFmoxI7losjp/ZM1NaT3gCg1aiT
470Dva/SMk+EnaGocCgHXd0=
=8al2
-----END PGP SIGNATURE-----
--/e2eDi0V/xtL+Mc8--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020619232135.D37593>