Date: Mon, 23 Apr 2007 21:56:13 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Kevin Oberman <oberman@es.net> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 route6.c Message-ID: <20070423215540.A36917@maildrop.int.zabbadoz.net> In-Reply-To: <20070423204814.938B64506A@ptavv.es.net> References: <20070423204814.938B64506A@ptavv.es.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Apr 2007, Kevin Oberman wrote: >> Date: Mon, 23 Apr 2007 20:32:10 +0000 (UTC) >> From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> >> >> On Mon, 23 Apr 2007, Kevin Oberman wrote: >> >> Hi, >> >>>> From: "George V. Neville-Neil" <gnn@FreeBSD.org> >>>> Date: Mon, 23 Apr 2007 09:32:04 +0000 (UTC) >>>> Sender: owner-cvs-all@freebsd.org >>>> >>>> gnn 2007-04-23 09:32:04 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/netinet6 route6.c >>>> Log: >>>> Turn off route header processing for now due to issues pointed out >>>> by Philippe Biondi and Arnaud Ebalard. This is a temporary fix >>>> until more discussion can be had on the exact risks involved in >>>> allowing source routing in IPv6 >>>> >>>> Submitted by: itojun >>>> Reviewed by: jinmei >>>> MFC after: 1 day >>>> >>>> Revision Changes Path >>>> 1.13 +7 -0 src/sys/netinet6/route6.c >>> >>> I forgot to mention (and not George's issue) is that a bit of work is >>> needed on ipfw for IPv6 data types. I have hit several issues which I >>> worked around, but, ATM, it can't differentiate between RH0 and RH2 in a >>> filter. >> >> Just a five-minute-o-patch. I have not even compile time tested it. >> >> 'route' will still match any routing header. >> 'rh0' should match rh0, and 'rh2' should match rh2. >> >> http://sources.zabbadoz.net/freebsd/ipv6/patches/patch-20070423-ipfw-rh2.patch >> >> Let me know if it works (or not;-) >> > Boy, that was fast. Unfortunately, it does not compile: > > cc -O2 -fno-strict-aliasing -pipe -c /usr/src/sbin/ipfw/ipfw2.c > /usr/src/sbin/ipfw/ipfw2.c:1304: error: `EXT_RH0' undeclared here (not in a function) > /usr/src/sbin/ipfw/ipfw2.c:1304: error: initializer element is not constant > /usr/src/sbin/ipfw/ipfw2.c:1304: error: (near initialization for `ext6hdrcodes[6].x') > /usr/src/sbin/ipfw/ipfw2.c:1304: error: initializer element is not constant > /usr/src/sbin/ipfw/ipfw2.c:1304: error: (near initialization for `ext6hdrcodes[6]') > /usr/src/sbin/ipfw/ipfw2.c:1305: error: `EXT_RH2' undeclared here (not in a function) > /usr/src/sbin/ipfw/ipfw2.c:1305: error: initializer element is not constant > /usr/src/sbin/ipfw/ipfw2.c:1305: error: (near initialization for `ext6hdrcodes[7].x') > /usr/src/sbin/ipfw/ipfw2.c:1305: error: initializer element is not constant > /usr/src/sbin/ipfw/ipfw2.c:1305: error: (near initialization for `ext6hdrcodes[7]') > /usr/src/sbin/ipfw/ipfw2.c:1306: error: initializer element is not constant > /usr/src/sbin/ipfw/ipfw2.c:1306: error: (near initialization for `ext6hdrcodes[8]') > *** Error code 1 > > Stop in /usr/src/sbin/ipfw.c compiles here; make sure it picks up the new header. Doing a full buildworld is easiest;-) -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070423215540.A36917>