Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Dec 2025 14:16:14 +0000
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 875df1296923 - stable/15 - pf: Fix an off-by-one in pf_handle_getcreators()
Message-ID:  <6940182e.34851.ef65d9f@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/15 has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=875df1296923dea30880d660f834cff43737d1f0

commit 875df1296923dea30880d660f834cff43737d1f0
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-12-05 21:36:02 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-12-15 14:09:52 +0000

    pf: Fix an off-by-one in pf_handle_getcreators()
    
    Reviewed by:    kp
    Reported by:    Kevin Day <kevin@your.org>
    MFC after:      1 week
    Fixes:          a7191e5d7b62 ("pf: add a way to list creator ids")
    Differential Revision:  https://reviews.freebsd.org/D54083
    
    (cherry picked from commit 0795e9b53cf5be68955b49dce87f4800fdfd4a89)
---
 sys/netpfil/pf/pf_nl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netpfil/pf/pf_nl.c b/sys/netpfil/pf/pf_nl.c
index 73f018db0266..98d79729fb18 100644
--- a/sys/netpfil/pf/pf_nl.c
+++ b/sys/netpfil/pf/pf_nl.c
@@ -363,7 +363,7 @@ pf_handle_getcreators(struct nlmsghdr *hdr, struct nl_pstate *npt)
 
 	bzero(creators, sizeof(creators));
 
-	for (int i = 0; i < V_pf_hashmask; i++) {
+	for (int i = 0; i <= V_pf_hashmask; i++) {
 		struct pf_idhash *ih = &V_pf_idhash[i];
 		struct pf_kstate *s;
 


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6940182e.34851.ef65d9f>