Date: Tue, 12 Dec 2000 10:51:46 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Marcel Moolenaar <marcel@cup.hp.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include mutex.h Message-ID: <XFMail.001212105146.jhb@FreeBSD.org> In-Reply-To: <3A367222.1EDB3221@cup.hp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12-Dec-00 Marcel Moolenaar wrote: > John Baldwin wrote: >> >> > Modified files: >> > sys/i386/include mutex.h >> > Log: >> > Fix the assembly mutex macros to call the appropriate witness functions >> > if >> > the witness code is compiled in. Without this, the witness code doesn't >> > notice that sched_lock is released by fork_trampoline() and thus gets >> > all >> > confused about spin lock order later on. >> >> Similar work needs to be done on the alpha and ia64 as well. Right now >> fork_trampoline() is the only case this kicks in, but the light weight >> context >> switches will rely on this even more. > > I'll take a look at ia64. I'm already in the process of getting the port > back into shape (sort of)... It might be easier to just call the _mtx_enter() and _mtx_exit() functions than to go through the hassles of coding up calls to witness and mutex operations in complete asm. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001212105146.jhb>