Date: Wed, 23 Feb 2005 15:03:22 +0100 From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) To: Gleb Smirnoff <glebius@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/etc syslog.conf Message-ID: <863bvnl6fp.fsf@xps.des.no> In-Reply-To: <20050223134627.GA21396@cell.sick.ru> (Gleb Smirnoff's message of "Wed, 23 Feb 2005 16:46:27 %2B0300") References: <200502220803.j1M839fn013604@repoman.freebsd.org> <20050222021322.U702@odysseus.silby.com> <20050222082558.GB10624@cell.sick.ru> <20050223043325.X718@odysseus.silby.com> <20050223134627.GA21396@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Gleb Smirnoff <glebius@freebsd.org> writes:
> Yes, a good plan. btw, syslogd does some ratelimiting itself. However, when
> system is low on kernel memory, new valid ARP entries fail to install
> with _two_ debug messages. Since two different messages are printed one
> after other, syslogd's limiting does not work. Example:
>
> Feb 2 09:00:01 <kern.debug> gw-core1 /kernel: arplookup 217.72.145.208 failed:
> could not allocate llinfo
> Feb 2 09:00:01 <kern.debug> gw-core1 /kernel: arpresolve: can't allocate llinfo
> for 217.72.145.208rt
The second message can simply be removed, since (from my quick reading
of the code) it can only occur if the first has already occurred.
DES
--
Dag-Erling Smørgrav - des@des.no
[-- Attachment #2 --]
Index: sys/netinet/if_ether.c
===================================================================
RCS file: /home/ncvs/src/sys/netinet/if_ether.c,v
retrieving revision 1.133
diff -u -r1.133 if_ether.c
--- sys/netinet/if_ether.c 7 Jan 2005 01:45:44 -0000 1.133
+++ sys/netinet/if_ether.c 23 Feb 2005 14:02:38 -0000
@@ -388,9 +388,6 @@
rt = la->la_rt;
}
if (la == 0 || rt == 0) {
- log(LOG_DEBUG, "arpresolve: can't allocate llinfo for %s%s%s\n",
- inet_ntoa(SIN(dst)->sin_addr), la ? "la" : "",
- rt ? "rt" : "");
m_freem(m);
return (EINVAL); /* XXX */
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?863bvnl6fp.fsf>