Date: Wed, 2 Apr 2014 10:21:26 -0700 From: Craig Rodrigues <rodrigc@FreeBSD.org> To: Peter Holm <peter@holm.cc> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: ATF work Message-ID: <CAG=rPVep6wrby4cej0fWSNtYrRhHLn5eOjDsNWWTYv0RpjDqUw@mail.gmail.com> In-Reply-To: <CAOtMX2gGn5NMpvSR0FF=z70cUCDn=vTQvVWo2mXk8t9UrNKzuA@mail.gmail.com> References: <20140402085349.GA61802@x2.osted.lan> <CAOtMX2gGn5NMpvSR0FF=z70cUCDn=vTQvVWo2mXk8t9UrNKzuA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers <asomers@freebsd.org> wrote: > On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm <peter@holm.cc> wrote: >> I have uploaded a snapshot of the ATF work done for EMC Isilon, >> based primarily on Garrett Cooper's work. >> >> http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz >> + >> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr > > Holy patch queue, Batman! There's fifty thousand lines of code in here! When a patch is that big, it becomes very difficult to review. You might want to consider forking a copy on github of the https://github.com/freebsd/freebsd repository and maintaining the patch there until it is MFC'd: https://help.github.com/articles/fork-a-repo https://help.github.com/articles/syncing-a-fork It's not perfect but some of the web interface tools around the github ecosystem make reviewing patches (and contributing updates) a bit easier. -- Craig
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVep6wrby4cej0fWSNtYrRhHLn5eOjDsNWWTYv0RpjDqUw>