Date: Mon, 04 Feb 2019 21:07:00 +0000 From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 233949] [rtwn] if_rtwn packet loss 10-25% Message-ID: <bug-233949-21060-Xd4jTLg4Jp@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233949-21060@https.bugs.freebsd.org/bugzilla/> References: <bug-233949-21060@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233949 --- Comment #10 from mr_beaner_2003@yahoo.com --- It seems there are some data type mismatches, which may be resulting in undefined behavior. This is probably more appropriate, after reviewing the data structures... Index: /usr/src/sys/dev/rtwn/rtl8192c/r92c_rx.c =================================================================== --- /usr/src/sys/dev/rtwn/rtl8192c/r92c_rx.c (revision 343552) +++ /usr/src/sys/dev/rtwn/rtl8192c/r92c_rx.c (working copy) @@ -83,10 +83,10 @@ r92c_get_rssi_ofdm(struct rtwn_softc *sc, void *physt) { struct r92c_rx_phystat *phy = (struct r92c_rx_phystat *)physt; - int rssi; + uint8_t rssi = phy->pwdb_all; /* Get average RSSI. */ - rssi = ((phy->pwdb_all >> 1) & 0x7f) - 110; + rssi = ((rssi >> 1) & 0x7f) - 110; return (rssi); } -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233949-21060-Xd4jTLg4Jp>