Date: Wed, 23 Apr 2008 14:42:43 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: emulation@freebsd.org Subject: Re: [RFC]: a place for [f]truncate64 Message-ID: <20080423114242.GY18958@deviant.kiev.zoral.com.ua> In-Reply-To: <20080423112543.GA20954@freebsd.org> References: <20080423112543.GA20954@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--i6jgfrJswdyoXnQp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Apr 23, 2008 at 01:25:43PM +0200, Roman Divacky wrote:
> hi,
>=20
> Linux defines two syscalls ftruncate64 and truncate64 that are
> defined only on 32bit archs, currently Linuxulator implementes
> ftruncate64 which is defined in linux[32]_machdep.c, ie. in
> machine dependant file.
>=20
> I plan to commit truncate64 but I prefer it to be placed in
> linux_file.c which is machine independent. Kostik and I had
> a discussion about this yesterday and we didnt agree what
> is the best place for these functions.
>=20
> I think it's better to have it in linux_file.c because the
> only problem that can arise is that on platforms that don't
> use these syscalls there will be unused function in linux_file.c
> Kostik prefers each linux[32]_machdep.c to have it's own copy.
>=20
> So I ask emulation@ what should be done, do we want this in linux_file.c
> or linux[32]_machdep.c
It is wrong to limit the discussion to not quite interesting case of the
truncate64. There is a lot more duplication, see the linux{,32}_machdep.c.
I would prefer to have some definite word on the reason for this.
--i6jgfrJswdyoXnQp
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (FreeBSD)
iEYEARECAAYFAkgPILIACgkQC3+MBN1Mb4i47gCg90CGs1Aw/QXQ2yklOKLAK0IN
gwkAnjoRFZ3HaTUbR2wlzgqWySbgvkzp
=FriD
-----END PGP SIGNATURE-----
--i6jgfrJswdyoXnQp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080423114242.GY18958>