Date: Mon, 19 Sep 2016 22:19:04 -0600 From: Warner Losh <imp@bsdimp.com> To: Ronald Klop <ronald-lists@klop.ws>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r305968 - head/etc/autofs Message-ID: <CANCZdfpY%2Br3p2z6f59ZD7Vq2a60zMNpCncU3F0aaDu=kdHitgg@mail.gmail.com> In-Reply-To: <20160920034337.GA6180@brick> References: <201609190851.u8J8pRDD068198@repo.freebsd.org> <op.yn1u4maukndu52@d93fd8ae.cm-21.dynamic.ziggo.nl> <20160920034337.GA6180@brick>
next in thread | previous in thread | raw e-mail | index | archive | help
For MSDOS it's one thing and likely helps. But for ufs it doesn't help. Soft updates already does an excellent job at reducing wear and all async does is give added danger of dataloss. Linux distros don't matter for UFS because different design decisions have been made for ext[234] and UFS. Warner On Mon, Sep 19, 2016 at 9:43 PM, Edward Tomasz Napierala <trasz@freebsd.org> wrote: > Mounting removable media async improves performance and reduces wear. > And AFAIK that's what most Linux distros used to do. > > On 0919T2032, Ronald Klop wrote: >> Hi, >> >> Your commit message says in words exactly what the diff says in code. >> Would you like to elaborate on why the change is made? I'm curious >> because this could cause severe damage to the filesystem on unclean eject >> of the media. >> >> Regards, >> Ronald. >> >> >> On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala >> <trasz@freebsd.org> wrote: >> >> > Author: trasz >> > Date: Mon Sep 19 08:51:27 2016 >> > New Revision: 305968 >> > URL: https://svnweb.freebsd.org/changeset/base/305968 >> > >> > Log: >> > Make autofs use the "async" flag for msdosfs and ufs filesystems >> > mounted >> > on /media. >> > MFC after: 1 month >> > >> > Modified: >> > head/etc/autofs/special_media >> > >> > Modified: head/etc/autofs/special_media >> > ============================================================================== >> > --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 (r305967) >> > +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 (r305968) >> > @@ -46,6 +46,8 @@ print_map_entry() { >> > "Cannot mount ${_fstype} formatted device /dev/${_p}: Install >> > sysutils/fusefs-ntfs first" >> > exit 1 >> > fi >> > + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then >> > + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" >> > else >> > echo "-fstype=${_fstype},nosuid :/dev/${_p}" >> > fi >> > _______________________________________________ >> > svn-src-all@freebsd.org mailing list >> > https://lists.freebsd.org/mailman/listinfo/svn-src-all >> > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpY%2Br3p2z6f59ZD7Vq2a60zMNpCncU3F0aaDu=kdHitgg>