Date: Wed, 18 May 2011 04:32:44 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Andriy Gapon <avg@freebsd.org> Subject: Re: svn commit: r222051 - in head/sys/dev: sound/usb usb usb/input usb/storage Message-ID: <BANLkTimVxubKOgz_0bwpFJ_%2BOHmq=iPs0g@mail.gmail.com> In-Reply-To: <201105181320.24252.hselasky@freebsd.org> References: <201105180740.p4I7eCVx066426@svn.freebsd.org> <201105181320.24252.hselasky@freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Wed, May 18, 2011 at 4:20 AM, Hans Petter Selasky <hselasky@freebsd.org> wrote: > On Wednesday 18 May 2011 09:40:12 Andriy Gapon wrote: >> Author: avg >> Date: Wed May 18 07:40:12 2011 >> New Revision: 222051 >> URL: http://svn.freebsd.org/changeset/base/222051 >> >> Log: >> usb: change to one-pass probing of device drivers >> >> This brings USB bus more in line with how newbus is supposed to be used. >> Also, because of the two-pass probing the following message was produced >> by devd in default configuration when almost any USB device was >> connected: >> Unknown USB device: vendor <> product <> bus <> >> This should be fixed now. >> >> Note that many USB device drivers pass some information from probe >> method to attach method via ivars. For this to continue working we rely >> on the fact that the subr_bus code calls probe method of a winning driver >> again before calling its attach method in the case where multiple >> drivers claim to support a device. This is done because device >> description is set in successful probe methods and we want to get a >> correct device description from a winning driver. So now this logic is >> re-used for setting ivars too. >> >> Reviewed by: hselasky >> MFC after: 1 month >> >> Modified: >> head/sys/dev/sound/usb/uaudio.c >> head/sys/dev/usb/input/uhid.c >> head/sys/dev/usb/input/ukbd.c >> head/sys/dev/usb/input/ums.c >> head/sys/dev/usb/storage/umass.c >> head/sys/dev/usb/storage/ustorage_fs.c >> head/sys/dev/usb/usb_device.c >> head/sys/dev/usb/usbdi.h >> > > Looks like you missed ng_ubt.c. Just do a "grep -r" for the replaced fields. The patch I sent offline to you guys was the only affected file based on a grep around /sys/... ; I based my patch on other code patterns in this commit. Thanks! -Garretthelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimVxubKOgz_0bwpFJ_%2BOHmq=iPs0g>