Date: Mon, 2 Dec 2013 17:26:03 -0500 From: Glen Barber <gjb@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Hiroki Sato <hrs@freebsd.org>, src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r258848 - user/hrs/releng/release Message-ID: <20131202222603.GH85910@glenbarber.us> In-Reply-To: <201312021613.30872.jhb@freebsd.org> References: <201312021440.rB2EeQa6012210@svn.freebsd.org> <20131202145103.GG1839@glenbarber.us> <201312021613.30872.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--J/zg8ciPNcraoWb6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 02, 2013 at 04:13:30PM -0500, John Baldwin wrote: > On Monday, December 02, 2013 9:51:03 am Glen Barber wrote: > > On Mon, Dec 02, 2013 at 02:40:26PM +0000, Hiroki Sato wrote: > > > Author: hrs > > > Date: Mon Dec 2 14:40:26 2013 > > > New Revision: 258848 > > > URL: http://svnweb.freebsd.org/changeset/base/258848 > > >=20 > > > Log: > > > Improve robustness and consistency, and remove redundant lines with= no > > > major functional change: > >=20 > > > [...] > >=20 > > > +if [ $($ID -u) -ne 0 ]; then > > > + echo 1>&2 "$0: Needs to be run as root." > > > + exit 1 > > > +fi > > > # The directory within which the release will be built. > > > -CHROOTDIR=3D"/scratch" > > > +: ${CHROOTDIR:=3D/scratch} > > > +: ${CHROOT_CMD:=3Dchroot $CHROOTDIR} > > > +: ${DESTDIR=3D:/R/} > > > +: ${MAKEOBJDIRPREFIX:=3D/usr/obj} > > > =20 > >=20 > > Please do not merge these changes to head/. It was intentional that > > environment was not honored, as everything should be set in the > > configuration file. > >=20 > > It is possible to use the environment in the configuration file, such > > as: > >=20 > > ---- release.conf ---- > > : ${_DESTDIR=3D:/R/} > > DESTDIR=3D${_DESTDIR} > > ---- release.conf ---- >=20 > OTOH, I have hacked release.sh at my work specifically in this manner > since I use a wrapper script to invoke release.sh and don't want to have > to create a temporary file, etc. I tried using this approach for > release.conf when you suggested and it did not work IIRC. >=20 Can you provide a sample of what did not work? Last I recall you and I talking about it, the suggestion above worked for you. Glen --J/zg8ciPNcraoWb6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBCAAGBQJSnQj7AAoJELls3eqvi17Qz5oP/3gCwsAWsgy1Nx2FUw2yNsln vLxOBjeW/fbTfMODMA0o9eJNbMdKqc/RLqLeIgXFQiCg6kXH5ZPpkmB2EWdUBVK1 6/FrP8M9psRcmEeIcGJqgadg3FbtIERPhNIoAlFZ2UZy5SavAyn/cyh4G1/EuMcI 2G+0BWvHbBL4Gadt0vBvCDFWZv6PAzFjsyzEKFBAlFjleBusYesFXVJQsAA6RQfY 1ZMCQJ04mE1qlygn7ky4MEarL5WCz9kBdWVSL9j49aTi1k3vjpB5eviQZ7LHkqA2 O7J+c0iP0NkeYXVG4XNDd6o5FguPKNjqU1tvZQ2STm+H7fXa1KA4zE2VTk//69cF 8r7GqGjaXW2L/XQkCZaJbgId6kxpfC7TxdiJwLH7JAHiJ4ahoY+iZAXQmQSn9gqS RILItn/I7W6vAWAaw6HnqbHOmV+16g6FLBzSX6FqFO/vzWyav0iI6OaRLTnoxrZs P2FQp7OgLsfer4z+te32P4lIZxXf+oNYUfnfdPb23Tt6OjrAbKjaSSiocISIYfrz pwrLWE4M/HaeZiqD+rLLi6ju2bGIxXAlroNgwPsCLzuQMl2NVf2SsI+H403FlobV eSIcmAr8JP+k1i1Xj0iIx8x2ucpiHDtQH8ujvYaw+46CnDdw7oEaq0IGWGKJmMiy dkniKa41TIh4Uoa2yMtX =rzfC -----END PGP SIGNATURE----- --J/zg8ciPNcraoWb6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131202222603.GH85910>