Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Mar 2023 03:45:07 +0000
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 44357c18ccb9 - main - ppp: Remove trailing semicolon
Message-ID:  <27233978-E3A2-46BD-A2A9-BA1854833129@freebsd.org>
In-Reply-To: <202303150239.32F2dj2H060188@gitrepo.freebsd.org>
References:  <202303150239.32F2dj2H060188@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 15 Mar 2023, at 02:39, Warner Losh <imp@FreeBSD.org> wrote:
>=20
> The branch main has been updated by imp:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D44357c18ccb9df24a925d43ccc467f65=
b9ed6bc6
>=20
> commit 44357c18ccb9df24a925d43ccc467f65b9ed6bc6
> Author:     Elyes Haouas <ehaouas@noos.fr>
> AuthorDate: 2023-03-15 02:09:16 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2023-03-15 02:39:34 +0000
>=20
>    ppp: Remove trailing semicolon
>=20
>    Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
>    Reviewed by: imp
>    Pull Request: https://github.com/freebsd/freebsd-src/pull/654
> ---
> usr.sbin/ppp/ncp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/usr.sbin/ppp/ncp.h b/usr.sbin/ppp/ncp.h
> index 70b00a422310..806c943a891e 100644
> --- a/usr.sbin/ppp/ncp.h
> +++ b/usr.sbin/ppp/ncp.h
> @@ -96,8 +96,8 @@ extern void ncp2initial(struct ncp *);
>           ncp_ClearUrgentPorts(&(ncp)->cfg.urgent.tcp)
> #define ncp_ClearUrgentUdpPorts(ncp) \
>           ncp_ClearUrgentPorts(&(ncp)->cfg.urgent.udp)
> -#define ncp_ClearUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 0;
> -#define ncp_SetUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 1;
> +#define ncp_ClearUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 0
> +#define ncp_SetUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 1

do { ... } while (0)?

Jess

>=20
> #ifndef NOINET6
> #define isncp(proto) ((proto) =3D=3D PROTO_IPCP || (proto) =3D=3D =
PROTO_IPV6CP)




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?27233978-E3A2-46BD-A2A9-BA1854833129>