Date: Tue, 16 Aug 2016 08:57:54 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 211773] [NEW PORT] net/mod_amd: Asterisk app_amd for FreeSWITCH Message-ID: <bug-211773-13-8c6pGzkQLa@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211773-13@https.bugs.freebsd.org/bugzilla/> References: <bug-211773-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211773 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #8 from Kubilay Kocak <koobs@FreeBSD.org> --- Thank you =C5=A0imun, nice work :) A few (non-obvious) issues remain that high-quality ports don't exhibit. 1) Warning: 'lib/freeswitch/mod/mod_amd.so' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} That can be addressed in a post-install: target using ${STRIP_CMD} ${STAGEDIR}/path/to/file.so because the upstream Makefile doesn't have an install-strip target 2) Use at least the -AC flags with portlint (add -N for new ports like this one) for extra checks (some may be false positives, use common sense) 3) Patch out -Werror. This flag shouldn't be included by upstreams in their releases. If it ends up there anyway, it needs to be overriden with -Wno-er= ror, or, removed entirely if a bad Makefile "inadvertently" overrides user-suppl= ied variables/flags, which mod_amd appears to :[ ).=20 3) Patch the Makefile to remove the @ (silencing command) charin the line containing "@$(CC)". The build currently only produces "--- mod_amd.o ---" output when compiling, and builds should be verbose. I only noticed this because I was looking for -Werror in the compile output and couldn't find it (because the build wasn't verbose) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211773-13-8c6pGzkQLa>