Date: Fri, 31 May 2002 14:10:48 +1000 (EST) From: Peter Jeremy <peter.jeremy@alcatel.com.au> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/38758: Misleading wait channel name in bwrite() Message-ID: <200205310410.g4V4Am5i045081@gsmx07.alcatel.com.au>
next in thread | raw e-mail | index | archive | help
>Number: 38758
>Category: kern
>Synopsis: Misleading wait channel name in bwrite()
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu May 30 21:20:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Peter Jeremy
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
Alcatel Australia Limited
>Environment:
System: FreeBSD gsmx07.alcatel.com.au 5.0-CURRENT FreeBSD 5.0-CURRENT #2: Tue May 7 08:15:34 EST 2002 root@:/usr/obj/3.0/cvs/src/sys/gsmx i386
>Description:
When bwrite() is waiting for a background write to complete,
it uses "biord" as a wait channel. This seems somewhat
misleading. bufwait() uses "biowr" - which seems more reasonable.
(Alternatively, "biobgwr" or similar would differentiate it from
the sleep in bufwait().
>How-To-Repeat:
Code inspection.
>Fix:
Index: vfs_bio.c
===================================================================
RCS file: /home/CVSROOT/src/sys/kern/vfs_bio.c,v
retrieving revision 1.310
diff -u -r1.310 vfs_bio.c
--- vfs_bio.c 4 May 2002 19:24:55 -0000 1.310
+++ vfs_bio.c 31 May 2002 03:51:39 -0000
@@ -758,7 +758,7 @@
return (0);
}
bp->b_xflags |= BX_BKGRDWAIT;
- tsleep(&bp->b_xflags, PRIBIO, "biord", 0);
+ tsleep(&bp->b_xflags, PRIBIO, "biowr", 0);
if (bp->b_xflags & BX_BKGRDINPROG)
panic("bwrite: still writing");
}
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205310410.g4V4Am5i045081>