Date: Wed, 29 May 2024 17:18:21 GMT
From: Warner Losh <imp@FreeBSD.org>
To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject: git: b661d9e64d73 - main - Revert "checkstyle9.pl: Add check for missing space between ) {"
Message-ID: <202405291718.44THILvt069415@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=b661d9e64d73a244873fb2aa6c97e95a988fb758 commit b661d9e64d73a244873fb2aa6c97e95a988fb758 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2024-05-29 17:15:24 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2024-05-29 17:18:00 +0000 Revert "checkstyle9.pl: Add check for missing space between ) {" This reverts commit 6bad7d2486b373015db5917d7a9641266861c607. Turns out this special case wasn't necessary, and this was already detected and due to another error (running the script got dropped from my experimental scripts), I hadn't noticed. Sponsored by: Netflix --- tools/build/checkstyle9.pl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index 7c2b2c0f5b5b..24e33712ceda 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -1556,11 +1556,6 @@ sub process { } } -# Check for ){ - if ($rawline =~ /^.*\)\{\n/) { - ERROR("Missing space before brace\n". $herecurr); - } - # check for spaces before a quoted newline if ($rawline =~ /^.*\".*\s\\n/) { ERROR("unnecessary whitespace before a quoted newline\n" . $herecurr);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202405291718.44THILvt069415>