Date: Mon, 19 Sep 2016 13:14:29 -0700 From: John Baldwin <jhb@freebsd.org> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305981 - head/usr.bin/cmp Message-ID: <3626154.BMQsYkeuc4@ralph.baldwin.cx> In-Reply-To: <201609191613.u8JGD0GA036854@repo.freebsd.org> References: <201609191613.u8JGD0GA036854@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, September 19, 2016 04:13:00 PM Conrad E. Meyer wrote: > Author: cem > Date: Mon Sep 19 16:13:00 2016 > New Revision: 305981 > URL: https://svnweb.freebsd.org/changeset/base/305981 > > Log: > cmp(1): Capsicumify > > Reviewed by: allanjude, bapt, oshogbo > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D7912 > > Modified: > head/usr.bin/cmp/cmp.c > > Modified: head/usr.bin/cmp/cmp.c > ============================================================================== > --- head/usr.bin/cmp/cmp.c Mon Sep 19 16:07:32 2016 (r305980) > +++ head/usr.bin/cmp/cmp.c Mon Sep 19 16:13:00 2016 (r305981) > @@ -42,15 +42,18 @@ static char sccsid[] = "@(#)cmp.c 8.3 (B > #include <sys/cdefs.h> > __FBSDID("$FreeBSD$"); > > +#include <sys/capsicum.h> > #include <sys/types.h> > #include <sys/stat.h> Style nit: why is <sys/capsicum.h> first? <sys/param.h> or <sys/types.h> should be first (from style(9)) then remaining sys/foo.h headers are alphabetically sorted after that. Does <sys/capsicum.h> have to be before <sys/types.h> for some reason? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3626154.BMQsYkeuc4>