Date: Sun, 13 Jun 2004 10:00:47 GMT From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/67900: New port: sysutils/jail Builds a chrooted environment Message-ID: <200406131000.i5DA0lR2006205@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/67900; it has been noted by GNATS. From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: bugghy <bugghy@phenix.rootshell.be> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/67900: New port: sysutils/jail Builds a chrooted environment Date: Sun, 13 Jun 2004 11:55:43 +0200 bugghy wrote: >> Synopsis: New port: sysutils/jail Builds a chrooted environment The term `jail' is already taken in FreeBSD, meaning something different. You should choose a different name and patch the port accordingly. > X INSTALL_DIR = /usr/local > X PERL = /usr/bin/perl Don't hard code these paths. > X-mv /tmp/jail.conf.tmp /tmp/jail.conf > X-install_file /tmp/jail.conf $4/etc $5 $6 $7 > X-rm /tmp/jail.conf > X+mv /tmp/jail.conf.tmp /tmp/jail.conf.sample > X+install_file /tmp/jail.conf.sample $4/etc $5 $6 $7 > X+rm /tmp/jail.conf.sample Hard coded names in temporary file are often open to symlink attacks. Did you check that there are no problems here? > XMASTER_SITES= > http://switch.dl.sourceforge.net/sourceforge/jail/ You should use MASTER_SITE_SOURCEFORGE_EXTENDED (or without _EXTENDED) here. > XNO_INSTALL_MANPAGES= yes This does only make sense when you USE_IMAKE. > Xpost-install: > X.if !defined(NOPORTDOCS) > X ${MKDIR} ${DOCSDIR} > X ${INSTALL_MAN} ${WRKSRC}/../doc/CHANGELOG ${DOCSDIR} > X ${INSTALL_MAN} [...] These are not MAN pages, but DATA. > X @${CAT} ${PKGMESSAGE} > X.endif This should not be conditionalized on NOPORTDOCS. > Xbin/jail See above. Please don't use `jail'. > X################################################################### > X# Installed additional documentation in: ${PREFIX}/share/doc/jail # > X# Copy ${PREFIX}/etc/jail.conf.sample to ${PREFIX}/etc/jail.conf # > X################################################################### You could ${SED} %%PREFIX%% by its real value here. Another not: it seems like this port needs perl, but I haven't seen any USE_PERL5 here.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406131000.i5DA0lR2006205>