Date: Tue, 22 Jul 2003 19:18:22 -0500 From: "Jacques A. Vidrine" <nectar@FreeBSD.org> To: Simon Barner <barner@in.tum.de> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins Message-ID: <20030723001822.GA12440@madman.celabo.org> In-Reply-To: <20030722235756.GB607@zi025.glhnet.mhn.de> References: <20030718025200.GA36893@rot13.obsecurity.org> <20030722122608.GC552@zi025.glhnet.mhn.de> <20030722195637.GC10922@madman.celabo.org> <20030722235756.GB607@zi025.glhnet.mhn.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 23, 2003 at 01:57:56AM +0200, Simon Barner wrote:
> > > --- plugins/check_by_ssh.c.orig Mon Apr 23 09:43:11 2001
> > > +++ plugins/check_by_ssh.c Tue Jul 22 05:05:52 2003
> > > @@ -191,7 +191,7 @@
> > > if (commands>1)
> > > remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;");
> > >
> > > - if (strlen (remotecmd) <= 1)
> > > + if (remotecmd==NULL)
> > > usage ("No remotecmd\n");
> > >
> > > comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);
> >
> > This looks like more than a fix for a `compile failure'. The
> > replacement code has different semantics than the new code.
> > What is the `compile failure' that was being fixed here?
>
> I don't know, either. This patch was part of the port before I touched
> it [1].
Oh, well nevermind! I thought this was a new patch to deal with
`compile failures'. Cheers!
> Perhaps one should write
>
> if ((remotecmd==NULL) || (strlen (remotecmd) <= 1))
>
> to be on the safe side?
Maybe. The original submittor might recall.
Cheers,
--
Jacques Vidrine . NTT/Verio SME . FreeBSD UNIX . Heimdal
nectar@celabo.org . jvidrine@verio.net . nectar@freebsd.org . nectar@kth.se
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030723001822.GA12440>