Date: Sun, 20 Aug 2006 21:55:25 +0300 From: Giorgos Keramidas <keramida@FreeBSD.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: Brooks Davis <brooks@one-eyed-alien.net>, Dag-Erling Sm?rgrav <des@des.no>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr Message-ID: <20060820185525.GA12000@gothmog.pc> In-Reply-To: <20060818153744.GA14726@comp.chem.msu.su> References: <200608181210.k7ICAIme084410@repoman.freebsd.org> <86ejvet9m6.fsf@xps.des.no> <20060818143310.GA14203@comp.chem.msu.su> <20060818143508.GA2545@lor.one-eyed-alien.net> <20060818153744.GA14726@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2006-08-18 19:37, Yar Tikhiy <yar@comp.chem.msu.su> wrote:
> On Fri, Aug 18, 2006 at 09:35:08AM -0500, Brooks Davis wrote:
> > On Fri, Aug 18, 2006 at 06:33:11PM +0400, Yar Tikhiy wrote:
> > > On Fri, Aug 18, 2006 at 04:13:37PM +0200, Dag-Erling Sm?rgrav wrote:
> > > > Yar Tikhiy <yar@FreeBSD.org> writes:
> > > > > Log:
> > > > > The ps(1) command is unfriendly to scripts by default because
> > > > > it limits the width of its output to the value of $COLUMNS, or
> > > > > what TIOCGWINSZ reports, or 79 columns. We should specify -ww
> > > > > to ps(1) so that it removes the limit and prints lines in full.
> > > > > Otherwise very long command pathnames could be mishandled, e.g.,
> > > > > by _find_processes().
> > > >
> > > > or perhaps _find_processes() should use pgrep(1) instead of ps(1).
> > >
> > > I considered that but had to stick to ps(1) because pgrep was in
> > > /usr/bin while ps was in /bin. The use of /usr/bin tools should
> > > be very limited in rc.subr(8). OTOH, pgrep uses /lib libs only,
> > > which makes it possible to transfer pgrep+pkill to /bin if we can
> > > stand the growth of / by some 50 kbytes.
> >
> > I think that's appropriate since pgrep is such an obvious fit for this
> > sort of thing. I think we'll want to consider compatability symlinks
> > due to existing hardcoded paths in scripts.
>
> Creating the compat symlinks should be as easy as adding the following
> lines to the Makefile:
>
> SYMLINKS= ${BINDIR}/pgrep /usr/bin/pgrep
> SYMLINKS+= ${BINDIR}/pkill /usr/bin/pkill
Hmmm. Shouldn't this be using ${DESTDIR} in the right-hand paths?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060820185525.GA12000>