Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Dec 2016 20:35:06 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        "O. Hartmann" <ohartmann@walstatt.org>
Cc:        FreeBSD CURRENT <freebsd-current@freebsd.org>, Toomas Soome <tsoome@FreeBSD.org>
Subject:   Re: r 310850: buildworld failure due to: nandfs.c:1049:15: error: too many arguments to function call, 
Message-ID:  <30C71053-94F3-44D1-9089-CE31E67912DF@FreeBSD.org>
In-Reply-To: <20161230202338.73e7d00b@thor.walstatt.dynvpn.de>
References:  <20161230202338.73e7d00b@thor.walstatt.dynvpn.de>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_750BFABF-EC7C-4C41-858F-F0A5871949EA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 30 Dec 2016, at 20:23, O. Hartmann <ohartmann@walstatt.org> wrote:
>=20
> Recent update of CURRENT to 2310850 fails with buildworld error:
>=20
> [...]
> =3D=3D=3D> lib/atf/libatf-c++ (all)
> --- all_subdir_lib/libstand ---
> --- nandfs.o ---
> /usr/src/lib/libstand/nandfs.c:1049:15: error: too many arguments to =
function call,
> expected 6, have 7 buffer, NULL);
>                            ^~~~
> /usr/obj/usr/src/tmp/usr/include/sys/_null.h:32:14: note: expanded =
from macro 'NULL'
> #define NULL    ((void *)0)
>                ^~~~~~~~~~~
> 1 error generated.
> *** [nandfs.o] Error code 1

This looks like the culprit to me:

On 30 Dec 2016, at 20:06, Toomas Soome <tsoome@FreeBSD.org> wrote:
> Author: tsoome
> Date: Fri Dec 30 19:06:29 2016
> New Revision: 310850
> URL: https://svnweb.freebsd.org/changeset/base/310850
>=20
> Log:
>  dosfs support in libstand is broken since r298230
>=20
>  Apparently the libstand dosfs optimization is a bit too optimistic
>  and did introduce possible memory corruption.
>=20
>  This patch is backing out the bad part and since this results in
>  dosfs reading full blocks now, we can also remove extra offset =
argument
>  from dv_strategy callback.
>=20
>  The analysis of the issue and the backout patch is provided by =
Mikhail Kupchik.
>=20
>  PR:		214423
>  Submitted by:	Mikhail Kupchik
>  Reported by:	Mikhail Kupchik
>  Reviewed by:	bapt, allanjude
>  Approved by:	allanjude (mentor)
>  MFC after:	1 month
>  Differential Revision:	https://reviews.freebsd.org/D864

For some reason, your build seems to pick up an older stand.h header?

-Dimitry


--Apple-Mail=_750BFABF-EC7C-4C41-858F-F0A5871949EA
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.30

iEYEARECAAYFAlhmtvEACgkQsF6jCi4glqNBxQCg4pXuGX/ceECiXHNY5tPbYEEJ
9vEAoIwuYogT22U/Xez+TkIa+Rx/Wbzj
=9ywB
-----END PGP SIGNATURE-----

--Apple-Mail=_750BFABF-EC7C-4C41-858F-F0A5871949EA--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30C71053-94F3-44D1-9089-CE31E67912DF>