Date: Sun, 1 Feb 2009 19:38:47 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: "M. Warner Losh" <imp@bsdimp.com> Cc: freebsd-usb@freebsd.org, thompsa@freebsd.org Subject: Re: USB2 patches Message-ID: <200902011938.48670.hselasky@c2i.net> In-Reply-To: <20090201.112756.1320088159.imp@bsdimp.com> References: <200902011220.18745.hselasky@c2i.net> <200902011922.16810.hselasky@c2i.net> <20090201.112756.1320088159.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 01 February 2009, M. Warner Losh wrote: > In message: <200902011922.16810.hselasky@c2i.net> > > Hans Petter Selasky <hselasky@c2i.net> writes: > : In your patch you remove all error checking! If the taskqueue system does > : not have an API function that can tell if the taskqueue is being drained > : from inside the taskqueue callback, the taskqueue system has to be > : modified! It cannot replace the existing system like it is now! > > Why does the taskqueue system need to provide that? Why can't the > driver set a dying flag in the softc to communicate this fact to the > taskqueue tasks? That's also possible. Thomas already made a "struct usb2_task" I think, where this flag could be added. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902011938.48670.hselasky>