Date: Sun, 9 Mar 2025 17:39:39 GMT From: Matthias Andree <mandree@FreeBSD.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: git: f87670494f1a - main - devel/py-breathe: repair havoc wreaked by bc7ed2ccd62e Message-ID: <202503091739.529Hdd7p035122@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by mandree: URL: https://cgit.FreeBSD.org/ports/commit/?id=f87670494f1a995214d9f979590aa0f7699aa6b9 commit f87670494f1a995214d9f979590aa0f7699aa6b9 Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2025-03-09 17:24:43 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2025-03-09 17:38:22 +0000 devel/py-breathe: repair havoc wreaked by bc7ed2ccd62e bc7ed2ccd62 was insufficiently made, so I will credit as: Broken by: vishwin@ PR: 270510 I herewith have recorded that this was in violation of long-standing best practice that we give maintainers ports affected by sweeping changes such as the one in bc7ed... sufficient heads-up so this can be properly reviewed before inflicting the damage. vishwin@ has been around the project for long enough that he should know this, and I observe that there is a strong imbalance of how this person opposes certain advances in the project, all the while applying different standards when bringing "his own" changes forward. Also, deprecating something via CHANGES without a clear alternative path forward is insufficient. Don't tell what your co-committers should not do without showing the proper way forward. For the record, this is damaging and such behaviors must change, urgently. To fix py-breathe: - Re-add setuptools as a dependency, and duly note that the CHANGES entry in the mentioned Git commit is utterly and completely insufficient WRT future directions. - Bump PORTREVISION to trigger rebuild attempts. Reported by: antoine@ (thank you very much for this suggestion) Tested by: diizzy@ Fixes: bc7ed2ccd62e - main - python.mk: remove setuptools from RUN_DEPENDS --- devel/py-breathe/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devel/py-breathe/Makefile b/devel/py-breathe/Makefile index 2d336a4ccbe0..0a2cdd7aba6a 100644 --- a/devel/py-breathe/Makefile +++ b/devel/py-breathe/Makefile @@ -1,6 +1,6 @@ PORTNAME= breathe PORTVERSION= 4.35.0 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= devel python PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -15,6 +15,7 @@ BUILD_DEPENDS= ${RUN_DEPENDS} \ ${PYTHON_PKGNAMEPREFIX}wheel>=0:devel/py-wheel@${PY_FLAVOR} RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}furo>=0:textproc/py-furo@${PY_FLAVOR} \ graphviz>=0:graphics/graphviz \ + ${PYTHON_PKGNAMEPREFIX}setuptools>=63.1.0:devel/py-setuptools@${PY_FLAVOR} \ ${PYTHON_PKGNAMEPREFIX}sphinx>=0,1:textproc/py-sphinx@${PY_FLAVOR} \ ${PYTHON_PKGNAMEPREFIX}sphinx-copybutton>=0:textproc/py-sphinx-copybutton@${PY_FLAVOR} \ doxygen:devel/doxygenhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503091739.529Hdd7p035122>