Date: Wed, 31 Aug 2022 14:15:36 +0300 From: Toomas Soome <tsoome@me.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "Bjoern A. Zeeb" <bz@FreeBSD.org>, Toomas Soome <tsoome@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: e3572eb65473 - main - Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU. Message-ID: <0DCA177E-9FD9-4DF8-A7EB-C29CA44B5116@me.com> In-Reply-To: <0F57FEEE-BDC0-4CE1-9349-D7E12556E158@freebsd.org> References: <202206262217.25QMHOuH076130@gitrepo.freebsd.org> <F0C6ECC7-E479-4FA8-ADAE-7229E045D771@freebsd.org> <alpine.BSF.2.00.2206262336110.68830@ai.fobar.qr> <CE2DC7A3-CB6B-4AC4-9F62-07302D501B61@freebsd.org> <alpine.BSF.2.00.2206270053420.68830@ai.fobar.qr> <1E37449E-B6C8-47A5-AD79-34F24138CC64@freebsd.org> <r9ro55p-7279-6s1s-q8rq-3q5r589768sq@SerrOFQ.bet> <0F57FEEE-BDC0-4CE1-9349-D7E12556E158@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Please see https://reviews.freebsd.org/D36401 <https://reviews.freebsd.org/D36401>; thanks, toomas > On 31. Aug 2022, at 01:05, Jessica Clarke <jrtc27@freebsd.org> wrote: > > On 30 Aug 2022, at 22:51, Bjoern A. Zeeb <bz@FreeBSD.org <mailto:bz@FreeBSD.org>> wrote: >> >> On Tue, 30 Aug 2022, Jessica Clarke wrote: >> >> Hi Jessica, >> >>> On 27 Jun 2022, at 01:58, Bjoern A. Zeeb <bz@FreeBSD.org> wrote: >>>> >>>> On Mon, 27 Jun 2022, Jessica Clarke wrote: >>>> >>>> Hi, >>>> >>>>> On 27 Jun 2022, at 01:26, Bjoern A. Zeeb <bz@FreeBSD.org> wrote: >>>>>> >>>>>> On Mon, 27 Jun 2022, Jessica Clarke wrote: >>>>>> >>>>>>> On 26 Jun 2022, at 23:17, Toomas Soome <tsoome@FreeBSD.org> wrote: >>>>>>>> >>>>>>>> The branch main has been updated by tsoome: >>>>>>>> >>>>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=e3572eb654733a94e1e765fe9e95e0579981d851 >>>>>>>> >>>>>>>> commit e3572eb654733a94e1e765fe9e95e0579981d851 >>>>>>>> Author: Aleksandr Rybalko <ray@freebsd.org> >>>>>>>> AuthorDate: 2022-02-16 00:19:19 +0000 >>>>>>>> Commit: Toomas Soome <tsoome@FreeBSD.org> >>>>>>>> CommitDate: 2022-06-26 18:52:26 +0000 >>>>>>>> >>>>>>>> Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU. >>>>>>>> >>>>>>>> Allocate event for DMC-620 and CMN-600 controllers PMU. >>>>>>>> Add events supported by DMC-620 and CMN-600 controllers PMU. >>>>>>>> >>>>>>>> Reviewed by: bz >>>>>>>> Sponsored By: ARM >>>>>>>> Sponsored By: Ampere Computing >>>>>>>> Differential Revision: https://reviews.freebsd.org/D35609 >>>>>>> >>>>>>> This includes the following (skipped due to lines) diff: >>>>>>> >>>>>>>> * 0x14100 0x0100 ARMv8 events >>>>>>>> + * 0x14200 0x0020 ARM DMC-620 clkdiv2 events >>>>>>>> + * 0x14220 0x0080 ARM DMC-620 clk events >>>>>>>> + * 0x14300 0x0100 ARM CMN-600 events >>>>>>> >>>>>>> >>>>>>> Not enough space was allocated for Armv8 events as it goes up to 0x3ff >>>>>>> in Armv8 (and beyond in later versions of the architecture). Downstream >>>>>>> we extend this range in CheriBSD as required for Morello’s events. >>>>>>> Please relocate these new events well past the end of the existing >>>>>>> Armv8 events so the space can remain contiguous. >>>>>> >>>>>> Should this be 0x3ff then as well btw? >>>>>> https://github.com/CTSRD-CHERI/cheribsd/commit/4ea869cd8b717ca0b07672eb7acc99bf949249de >>>>> >>>>> Well, 0x400 for count not max, but yes. We only extended as far as we >>>>> needed, not to cover the entire range (but intended to eventually >>>>> upstream it as the full v8 range). >>>>> >>>>>> Looking more closely it seems from ARMv8.1 onwards it goes up to 0xFFFF >>>>>> if I read 'Table D8-7 Allocation of the PMU event number space' of ARM >>>>>> DDI 0487H.a correctly? >>>>> >>>>> Yes, if you want to cover all the v8.1 space then you need to go that >>>>> high too, but it’ll get quite sparse in that range so it’s unclear if >>>>> we want to go ahead and do that already or try and be smarter (the >>>>> current EVENT_xH list would get a bit silly). We should probably >>>>> reserve all of it though at least so we can if we want to in future. >>>> >>>> I'll let you and Toomas sort that out. I am just trying to fix the >>>> build breakage as I kind-of pushed him to get the remaining bits in >>>> by accepting that review after scrolling through and it looking >>>> reasonable and addressing all comments from the previous review. >>>> That was all to unbreak an already earlier build breakage. >>>> >>>> Given it wasn't too late for me I was trying to get through it >>>> before falling asleep soon as well, especially now that the >>>> thunderstorms seems to have mostly passed. >>> >>> Nobody ever got round to addressing this, and it is in fact causing us >>> issues downstream now. However, there’s a rather more glaring problem: >>> >>>> @@ -1313,6 +1475,10 @@ pmc_init(void) >>>> >>>> /* Fill soft events information. */ >>>> pmc_class_table[n++] = &soft_class_table_descr; >>>> + >>>> + pmc_class_table[n++] = &cmn600_pmu_class_table_descr; >>>> + pmc_class_table[n++] = &dmc620_pmu_cd2_class_table_descr; >>>> + pmc_class_table[n++] = &dmc620_pmu_c_class_table_descr; >>> >>> This doesn’t work (even if you ifdef it appropriately like now exists >>> upstream). If there is no CMN-600 etc then PMC_CLASS_TABLE_SIZE, i.e. >>> cpu_info.pm_nclass, is not going to include those, so you cannot add >>> them to pmc_class_table otherwise you have a buffer overflow. >> >> I am just replying really given I am on Cc: hoping that Toomas will get to this. >> >> pmc_init() is libpmc, right? Does a simple #if 0 around these avert all >> issues for now or do the kernel bits also need backing out? >> >> I only have vague memories of multiple commit to unbreak this one from >> that night (which tried to fix a previous different breakage). >> Backing out everything might be more tedious than just reverting the >> commit hence asking if "disabling" it does fix the problems. > > The only commit to libpmc.c since then was to add the #ifdef. I believe > the kernel bits can stay, though the event numbers still collide with > what should have been reserved for Armv8-A’s full range, and what we > reserve downstream as we have hardware that uses those events for > documented counters. > >>> Given >>> this has broken libpmc on large swathes of AArch64 hardware (maybe >> >> That has taken a lot of time for anyone to notice :( > > It also took a long time for anyone to notice how broken libpmcstat is, > and only a handful of people have noticed it’s totally broken for PIEs. > People just aren’t using pmc much, especially on !x86… > > Jess > >>> without CHERI the memory corruption happens to not trample over >>> anything important for now, but who knows), can we please revert this >>> patch until a fixed version exists, with both the event numbers >>> reallocated and libpmc made suitably dynamic so as to not introduce >>> buffer overflows? >>> >>> Note that cmn600 only has an ACPI attachment so FDT-based systems will >>> definitely hit this case. >>> >>> Jess >>> >>> >> >> -- >> Bjoern A. Zeeb r15:7 [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Please see <span style="text-decoration: underline; font-family: Hack; background-color: rgb(255, 255, 255);" class=""><a href="https://reviews.freebsd.org/D36401" class="">https://reviews.freebsd.org/D36401</a></span><div class=""><font face="Hack" class=""><span style="background-color: rgb(255, 255, 255);" class=""><u class=""><br class=""></u></span></font></div><div class=""><font face="Hack" class=""><span style="background-color: rgb(255, 255, 255);" class=""><u class="">thanks,</u></span></font></div><div class=""><font face="Hack" class=""><span style="background-color: rgb(255, 255, 255);" class=""><u class="">toomas<br class=""></u></span></font><div><br class=""><blockquote type="cite" class=""><div class="">On 31. Aug 2022, at 01:05, Jessica Clarke <<a href="mailto:jrtc27@freebsd.org" class="">jrtc27@freebsd.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On 30 Aug 2022, at 22:51, Bjoern A. Zeeb <</span><a href="mailto:bz@FreeBSD.org" style="font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">bz@FreeBSD.org</a><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">> wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class="">On Tue, 30 Aug 2022, Jessica Clarke wrote:<br class=""><br class="">Hi Jessica,<br class=""><br class=""><blockquote type="cite" class="">On 27 Jun 2022, at 01:58, Bjoern A. Zeeb <<a href="mailto:bz@FreeBSD.org" class="">bz@FreeBSD.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">On Mon, 27 Jun 2022, Jessica Clarke wrote:<br class=""><br class="">Hi,<br class=""><br class=""><blockquote type="cite" class="">On 27 Jun 2022, at 01:26, Bjoern A. Zeeb <<a href="mailto:bz@FreeBSD.org" class="">bz@FreeBSD.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">On Mon, 27 Jun 2022, Jessica Clarke wrote:<br class=""><br class=""><blockquote type="cite" class="">On 26 Jun 2022, at 23:17, Toomas Soome <<a href="mailto:tsoome@FreeBSD.org" class="">tsoome@FreeBSD.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">The branch main has been updated by tsoome:<br class=""><br class="">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=e3572eb654733a94e1e765fe9e95e0579981d851" class="">https://cgit.FreeBSD.org/src/commit/?id=e3572eb654733a94e1e765fe9e95e0579981d851</a><br class=""><br class="">commit e3572eb654733a94e1e765fe9e95e0579981d851<br class="">Author: Aleksandr Rybalko <<a href="mailto:ray@freebsd.org" class="">ray@freebsd.org</a>><br class="">AuthorDate: 2022-02-16 00:19:19 +0000<br class="">Commit: Toomas Soome <<a href="mailto:tsoome@FreeBSD.org" class="">tsoome@FreeBSD.org</a>><br class="">CommitDate: 2022-06-26 18:52:26 +0000<br class=""><br class="">Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU.<br class=""><br class="">Allocate event for DMC-620 and CMN-600 controllers PMU.<br class="">Add events supported by DMC-620 and CMN-600 controllers PMU.<br class=""><br class="">Reviewed by: bz<br class="">Sponsored By: ARM<br class="">Sponsored By: Ampere Computing<br class="">Differential Revision: <a href="https://reviews.freebsd.org/D35609" class="">https://reviews.freebsd.org/D35609</a><br class=""></blockquote><br class="">This includes the following (skipped due to lines) diff:<br class=""><br class=""><blockquote type="cite" class="">* 0x14100<span class="Apple-tab-span" style="white-space: pre;"> </span>0x0100<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>ARMv8 events<br class="">+ * 0x14200<span class="Apple-tab-span" style="white-space: pre;"> </span>0x0020<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>ARM DMC-620 clkdiv2 events<br class="">+ * 0x14220<span class="Apple-tab-span" style="white-space: pre;"> </span>0x0080<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>ARM DMC-620 clk events<br class="">+ * 0x14300<span class="Apple-tab-span" style="white-space: pre;"> </span>0x0100<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>ARM CMN-600 events<br class=""></blockquote><br class=""><br class="">Not enough space was allocated for Armv8 events as it goes up to 0x3ff<br class="">in Armv8 (and beyond in later versions of the architecture). Downstream<br class="">we extend this range in CheriBSD as required for Morello’s events.<br class="">Please relocate these new events well past the end of the existing<br class="">Armv8 events so the space can remain contiguous.<br class=""></blockquote><br class="">Should this be 0x3ff then as well btw?<br class=""><a href="https://github.com/CTSRD-CHERI/cheribsd/commit/4ea869cd8b717ca0b07672eb7acc99bf949249de" class="">https://github.com/CTSRD-CHERI/cheribsd/commit/4ea869cd8b717ca0b07672eb7acc99bf949249de</a><br class=""></blockquote><br class="">Well, 0x400 for count not max, but yes. We only extended as far as we<br class="">needed, not to cover the entire range (but intended to eventually<br class="">upstream it as the full v8 range).<br class=""><br class=""><blockquote type="cite" class="">Looking more closely it seems from ARMv8.1 onwards it goes up to 0xFFFF<br class="">if I read 'Table D8-7 Allocation of the PMU event number space' of ARM<br class="">DDI 0487H.a correctly?<br class=""></blockquote><br class="">Yes, if you want to cover all the v8.1 space then you need to go that<br class="">high too, but it’ll get quite sparse in that range so it’s unclear if<br class="">we want to go ahead and do that already or try and be smarter (the<br class="">current EVENT_xH list would get a bit silly). We should probably<br class="">reserve all of it though at least so we can if we want to in future.<br class=""></blockquote><br class="">I'll let you and Toomas sort that out. I am just trying to fix the<br class="">build breakage as I kind-of pushed him to get the remaining bits in<br class="">by accepting that review after scrolling through and it looking<br class="">reasonable and addressing all comments from the previous review.<br class="">That was all to unbreak an already earlier build breakage.<br class=""><br class="">Given it wasn't too late for me I was trying to get through it<br class="">before falling asleep soon as well, especially now that the<br class="">thunderstorms seems to have mostly passed.<br class=""></blockquote><br class="">Nobody ever got round to addressing this, and it is in fact causing us<br class="">issues downstream now. However, there’s a rather more glaring problem:<br class=""><br class=""><blockquote type="cite" class="">@@ -1313,6 +1475,10 @@ pmc_init(void)<br class=""><br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>/* Fill soft events information. */<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>pmc_class_table[n++] = &soft_class_table_descr;<br class="">+<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>pmc_class_table[n++] = &cmn600_pmu_class_table_descr;<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>pmc_class_table[n++] = &dmc620_pmu_cd2_class_table_descr;<br class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span>pmc_class_table[n++] = &dmc620_pmu_c_class_table_descr;<br class=""></blockquote><br class="">This doesn’t work (even if you ifdef it appropriately like now exists<br class="">upstream). If there is no CMN-600 etc then PMC_CLASS_TABLE_SIZE, i.e.<br class="">cpu_info.pm_nclass, is not going to include those, so you cannot add<br class="">them to pmc_class_table otherwise you have a buffer overflow.<br class=""></blockquote><br class="">I am just replying really given I am on Cc: hoping that Toomas will get to this.<br class=""><br class="">pmc_init() is libpmc, right? Does a simple #if 0 around these avert all<br class="">issues for now or do the kernel bits also need backing out?<br class=""><br class="">I only have vague memories of multiple commit to unbreak this one from<br class="">that night (which tried to fix a previous different breakage).<br class="">Backing out everything might be more tedious than just reverting the<br class="">commit hence asking if "disabling" it does fix the problems.<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">The only commit to libpmc.c since then was to add the #ifdef. I believe</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">the kernel bits can stay, though the event numbers still collide with</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">what should have been reserved for Armv8-A’s full range, and what we</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">reserve downstream as we have hardware that uses those events for</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">documented counters.</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" class="">Given<br class="">this has broken libpmc on large swathes of AArch64 hardware (maybe<br class=""></blockquote><br class="">That has taken a lot of time for anyone to notice :(<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">It also took a long time for anyone to notice how broken libpmcstat is,</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">and only a handful of people have noticed it’s totally broken for PIEs.</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">People just aren’t using pmc much, especially on !x86…</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Jess</span><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Hack-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" class="">without CHERI the memory corruption happens to not trample over<br class="">anything important for now, but who knows), can we please revert this<br class="">patch until a fixed version exists, with both the event numbers<br class="">reallocated and libpmc made suitably dynamic so as to not introduce<br class="">buffer overflows?<br class=""><br class="">Note that cmn600 only has an ACPI attachment so FDT-based systems will<br class="">definitely hit this case.<br class=""><br class="">Jess<br class=""><br class=""><br class=""></blockquote><br class="">--<span class="Apple-converted-space"> </span><br class="">Bjoern A. Zeeb r15:7</blockquote></div></blockquote></div><br class=""></div></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0DCA177E-9FD9-4DF8-A7EB-C29CA44B5116>