Date: Thu, 11 Mar 2010 15:30:53 -0800 From: Weongyo Jeong <weongyo.jeong@gmail.com> To: Andrew Thompson <thompsa@freebsd.org> Cc: Garrett Cooper <yanefbsd@gmail.com>, powerpc@freebsd.org, FreeBSD Tinderbox <tinderbox@freebsd.org>, current@freebsd.org Subject: Re: [head tinderbox] failure on powerpc/powerpc Message-ID: <20100311233053.GY1295@weongyo> In-Reply-To: <20100311081035.GA45454@citylink.fud.org.nz> References: <201003110629.o2B6TVta094218@freebsd-current.sentex.ca> <7d6fde3d1003102248g31b179f7u3bfe848408f91f2e@mail.gmail.com> <20100311081035.GA45454@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 11, 2010 at 09:10:35PM +1300, Andrew Thompson wrote:
> On Wed, Mar 10, 2010 at 10:48:27PM -0800, Garrett Cooper wrote:
> > Weongyo, et all,
> >
> > On Wed, Mar 10, 2010 at 10:29 PM, FreeBSD Tinderbox
> > > /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c:2035: error: request for member 'sd_bus' in something not a structure or union
> > > *** Error code 1
> > >
> > > Stop in /src/sys/modules/siba_bwn.
> > > *** Error code 1
> > >
> > > Stop in /src/sys/modules.
> > > *** Error code 1
> > >
> > > Stop in /obj/powerpc/src/sys/LINT.
> > > *** Error code 1
> > >
> > > Stop in /src.
> > > *** Error code 1
> > >
> > > Stop in /src.
> > > TB --- 2010-03-11 06:29:31 - WARNING: /usr/bin/make returned exit code ?1
> > > TB --- 2010-03-11 06:29:31 - ERROR: failed to build lint kernel
> > > TB --- 2010-03-11 06:29:31 - 3629.47 user 614.12 system 4685.83 real
> >
> > Could someone please try this patch to see whether or not it fixes
> > the void* deref issue? I don't think it's style(9) correct, but it
> > might resolve the issue.
> > Thanks,
> > -Garrett
> >
> > Index: siba_core.c
> > ===================================================================
> > --- siba_core.c (revision 204996)
> > +++ siba_core.c (working copy)
> > @@ -2032,9 +2032,9 @@
> > siba_dma_translation(device_t dev)
> > {
> >
> > - KASSERT(device_get_ivars(dev)->sd_bus->siba_type == SIBA_TYPE_PCI,
> > - ("unsupported bustype %d\n",
> > - device_get_ivars(dev)->sd_bus->siba_type));
> > + KASSERT(((struct siba_softc *) device_get_ivars(dev))->sd_bus->siba_type ==
> > + SIBA_TYPE_PCI, ("unsupported bustype %d\n",
> > + ((struct siba_softc*) device_get_ivars(dev))->sd_bus->siba_type));
> >
>
> It was all getting a bit unwieldy, I committed a more simple fix in
> r205003.
Thank you for fix and sorry for break build.
regards,
Weongyo Jeong
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100311233053.GY1295>