Date: Fri, 12 Apr 2024 12:41:09 +0300 From: Max Brazhnikov <makc@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 0660187ad07f - main - cleanup: remove occurrences of WITH_DEBUG Message-ID: <CAJie3ypkRa2%2B_oF72WfjnxdRV8hxNCCV4aTexBP83XAhtdqPFA@mail.gmail.com> In-Reply-To: <202404120607.43C674EB042318@gitrepo.freebsd.org> References: <202404120607.43C674EB042318@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I don't quite understand something about ports options and features.
Can we have the same knob as an option and as a feature?
For example, graphics/glaxnimate has DEBUG in the OPTIONS_DEFINE and
the following lines in the Makefile:
.if !${PORT_OPTIONS:MDEBUG}
CXXFLAGS:= ${CXXFLAGS:C/-O([2-9]|[sz]|fast)/-O1/}
-fstack-protector-strong -fno-strict-aliasing
.endif
Now to build this port in the debug mode I have to set WITH_DEBUG and
enable DEBUG option at the same time.
We should either disallow having DEBUG in the options and check only
for WITH_DEBUG everywhere,
or WITH_DEBUG feature should set DEBUG option automatically.
Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJie3ypkRa2%2B_oF72WfjnxdRV8hxNCCV4aTexBP83XAhtdqPFA>