Date: Thu, 01 Oct 2009 08:56:57 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= <des@des.no>, "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis Message-ID: <1254401817.4255.14.camel@localhost> In-Reply-To: <86eipno12p.fsf@ds4.des.no> References: <200910010243.n912hpSM034846@svn.freebsd.org> <86eipno12p.fsf@ds4.des.no>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, 2009-10-01 at 12:33 +0200, Dag-Erling Smørgrav wrote: > Coleman Kane <cokane@FreeBSD.org> writes: > > - if (sc->ndis_80211 && vap) > > + if ((sc->ndis_80211 != NULL) && (vap != NULL)) > > sc->ndis_80211 is an int. NULL is a pointer. > > DES Thanks, fix committed... I know style(9) says I should have not bothered with the commit, but the assume-that-zero-is-false logic seemed egregious enough at the time to warrant correcting it. I just corrected it improperly in my haste. Enjoy being able to buildkernel again. I'll be sitting in the corner. -- Coleman Kane [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEABECAAYFAkrEpxkACgkQcMSxQcXat5eI4gCfSHbYhuNGf1ODEmDWyLVDy1R1 qGIAn2uu7dzSTuNFx5/EsIVSdhp4rxZ9 =Eu+W -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1254401817.4255.14.camel>