Date: Wed, 5 Oct 2005 13:55:15 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: Brooks Davis <brooks@FreeBSD.org>, FreeBSD Current <current@FreeBSD.org>, Andrew Thompson <thompsa@FreeBSD.org> Subject: Re: panic: ifc_free_unit: bit is already cleared Message-ID: <20051005205515.GA30350@odin.ac.hmc.edu> In-Reply-To: <20051005203639.GA20552@garage.freebsd.pl> References: <20051005024903.GA72743@heff.fud.org.nz> <20051005203639.GA20552@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Oct 05, 2005 at 10:36:39PM +0200, Pawel Jakub Dawidek wrote: > On Wed, Oct 05, 2005 at 03:49:03PM +1300, Andrew Thompson wrote: > +> Hi, > +> > +> I have found a repeatable panic with network device cloning, unfortunatly I am > +> unable to dump on this box. This is sparc64 with a 2 day old current. > > The order is wrong in vlan_modevent(). > > if_clone_detach() is freeing ifc_units field, so ifc_free_unit() should not > be called after that. > > This patch should fix the problem: > > http://people.freebsd.org/~pjd/patches/if_vlan.c.patch Yes. This does introduce a race in that a new interface could be created between the vlan_clone_destroy loop and the call to if_clone_detach. It's going to be hard to trigger, but it probably should be fixed. Since cloning isn't performance critical, I think adding a dead flag to the clone structure and failing all attempts once the flag is set. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDRD2zXY6L6fI4GtQRAkYcAJ95L5mfgqtdndQk2+/t94eJb4iEwwCff6Og 4NbDvw6k5op2qpWyV7D/jBQ= =vrdy -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051005205515.GA30350>