Date: Sun, 28 Nov 2021 18:53:06 +1100 From: Peter Jeremy <peterj@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: b19740f4ce7a - main - swap_pager: lock vnode in swapdev_strategy() Message-ID: <YaM1YrMAPVs2o%2Be0@server.rulingia.com> In-Reply-To: <YaLi2GaVq4YFsHtZ@kib.kiev.ua> References: <202111251935.1APJZA1e094731@gitrepo.freebsd.org> <YaC8j8ZwYotIKGSO@server.rulingia.com> <YaFtGQ8vVXScXdjZ@kib.kiev.ua> <YaLZ5rcBo6SxCGQK@server.rulingia.com> <YaLi2GaVq4YFsHtZ@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--silS3mqwC8aP56W6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021-Nov-28 04:00:56 +0200, Konstantin Belousov <kostikbel@gmail.com> wr= ote: >On Sun, Nov 28, 2021 at 12:22:46PM +1100, Peter Jeremy wrote: >> On 2021-Nov-27 01:26:17 +0200, Konstantin Belousov <kostikbel@gmail.com>= wrote: >The cause for your panic is not the network interface down state (in fact, >I think that interface state up), but as you correctly analyzed, the >call to vop_nostrategy(). It is there in stack because underlying filesys= tem >was unmounted, and the swap vnode was reclaimed, replacing NFS vop vector >with deadfs vop vector, which inherits from the default vop. OK. Thanks for that explanation. I saw deadfs was a potential option but hadn't checked. >The bit that I do not understand from your report, is why swapoff_all() did >not occured earlier. Your earlier report, where spurious ENOMEM came out >from swapoff(2) syscall, and which I fixed by the previous patch, means=20 >that there was an attempt to swapoff. The ENOMEM swapoff is before the actual shutdown. I suspect my inclusion of that confused you, sorry. >Still, the solution is, IMO, to swapoff before unmount. We do not need >swapin for flushing buffers. > >Please try this combined patch. I've had a couple of goes at rebooting whilst thrashing with lots of swap in use and it seems happy so I think the patch is good to go. Thanks for the patches. --=20 Peter Jeremy --silS3mqwC8aP56W6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmGjNVZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzSE0g//a9+oPJ2kgUiAGBYm2CcBgruJfRN2fsDCvvuZgmegnYO5vEpy8CEmQhpo ZmVom0O2uDkPv11fso9F11CUJE3qGf6vwukojFRhycbgSIwO77YrVNv1DKhw3gds K57Jn6TAJaeasL1C3Ki8DSHbrUu8GbeVbKexxGtv6ggR//+Wj4+Ei3NU1cDuCbmX IesDG+X1MzY3/2Wtsq1rg8aX+lDf/V1hpYLyldqou98h7svrb8Q2brZ/DP/kpy4V oLRGlwDL1JZcnKhd/cX8Wb2OMTg8Yd8kSeuUZ0SAgbBGXLonhpamAOxJbvsu0v6W AG12iYE/diCYpEKvPdHRcCGAEin51IjeGN6PMFU/oW2To3dov+PUgwO/zWl7cSqj puDugTaZa/Uop4AlvRCpQN+b4qqLXj1qI0j09QwR3NWvLfQ8ZAWP5uq7/Db9Tlca RiVdizQP5qvSoEih9BOpHEaAcLyN1rWW9uP+wVC9iGDlcvqdaghpPPv1+AeNonxj azWurUmImNbiialD4I8V1+9z3bMJMIOv0+Ox8+o+hJUlsWIlfeljXJPK8VxkOAaN TPjyPiNXWbB9ETon8v259DXSlW+kXfr6CJe0K9hOum1Fkw/gGjgHi1anvcPssubP lbmfE3deKwqgBqyOLnNIsfZ8yWKHPEtPSs3l9GkAUfjA4BUkWkU= =P0xN -----END PGP SIGNATURE----- --silS3mqwC8aP56W6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YaM1YrMAPVs2o%2Be0>