Date: Mon, 27 Apr 2026 16:20:12 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: =?us-ascii?B?PT91dGYtOD9RP0RhZy1FcmxpbmdfU209QzM9QjhyZ3Jhdj89?= <des@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently Message-ID: <A23772E7-6D51-46E6-BD9C-515D70C16BEA@gmail.com> In-Reply-To: <24831.1777314998@kaos.jnpr.net> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net>
index | next in thread | previous in thread | raw e-mail
> On Apr 27, 2026, at 11:36 AM, Simon J. Gerraty <sjg@juniper.net> wrote: > > Dag-Erling Smørgrav <des@freebsd.org> wrote: >>> The goal here is to ensure a line like that will be ignored. >> >> That's beside the point, which is that your regex is incorrect. It will >> treat e.g. `:foo` as a comment. > > Which is fine by me. > > That is not a syntax one commonly expects to see in rc.conf.d/* > > safe_eval is used it sitations where we are paranoid, > normally only wanting to read *verified* input, but there are exceptions > to every rule, and the goal of safe_set is to ensure nothing wicked gets > eval'd. So I don't mind rejecting :foo=bar Using `:` as a comment marker seems a bit esoteric (at best) — especially when it has other meanings in /bin/sh . I'd vote for reverting the change personally, but I’m not going to be adamant about it. Cheers, -Enjihome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A23772E7-6D51-46E6-BD9C-515D70C16BEA>