Date: Wed, 24 Feb 2021 05:22:35 GMT From: Cy Schubert <cy@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 6e822e99570f - main - rc: fix parse of $local_startup Message-ID: <202102240522.11O5MZ7B048268@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=6e822e99570fdf4c564be04840a054bccc070222 commit 6e822e99570fdf4c564be04840a054bccc070222 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2021-02-24 05:12:49 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2021-02-24 05:12:49 +0000 rc: fix parse of $local_startup 77e1ccbee3ed6c837929e4e232fd07f95bfc8294 introduced parallel execution of rc. It separated groups with line feeds (\n) and elements within groups using spaces. This is a natural separation due to rcorder using spaces and lines to separate elements within groups with groups of services separated by line feeds. 77e1ccbee3ed6c837929e4e232fd07f95bfc8294 parses the output from rcorder by setting $IFS. However it failed to reset $IFS to default ' \t\n' prior to calling find_local_scripts_new(), causing find_local_scripts_new() to fail parsing $local_startup for site-specific local rc scripts, i.e. ${LOCALBASE}/etc/rc.d. This caused daemons from ports and packages such as postfix, dovecot, nut, and others in ${LOCALBASE} not to be started. PR: 249192 MFC after: 3 week X-MFC with: 77e1ccbee3ed6c837929e4e232fd07f95bfc8294 --- libexec/rc/rc | 1 + 1 file changed, 1 insertion(+) diff --git a/libexec/rc/rc b/libexec/rc/rc index 722d7fe35884..b5bc188fc7c0 100644 --- a/libexec/rc/rc +++ b/libexec/rc/rc @@ -119,6 +119,7 @@ for _rc_group in ${files}; do done unset files local_rc +unset IFS # Now that disks are mounted, for each dir in $local_startup # search for init scripts that use the new rc.d semantics.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102240522.11O5MZ7B048268>