Date: Tue, 5 Jun 2018 20:41:06 +0000 (UTC) From: Rick Macklem <rmacklem@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r334670 - projects/pnfs-planb-server/sys/fs/nfsserver Message-ID: <201806052041.w55Kf6bj096747@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rmacklem Date: Tue Jun 5 20:41:06 2018 New Revision: 334670 URL: https://svnweb.freebsd.org/changeset/base/334670 Log: Thanks to a warning from the more recent clang, I caught the fact that the logic of this "if" was backwards. Weirdly interesting is that it still worked, because it matched the devid that was for the other mirror and still got rid of the layout. It did mean that it recalled layouts that didn't have to be recalled, but that was safe. Modified: projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c Modified: projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c ============================================================================== --- projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c Tue Jun 5 20:34:11 2018 (r334669) +++ projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c Tue Jun 5 20:41:06 2018 (r334670) @@ -6783,7 +6783,7 @@ nfsrv_flexmirrordel(char *devid, NFSPROC_T *p) tl += 3; for (j = 0; j < lyp->lay_mirrorcnt; j++) { tl++; - if (!NFSBCMP(devid, tl, NFSX_V4DEVICEID) + if (NFSBCMP(devid, tl, NFSX_V4DEVICEID) == 0) { /* Found one. */ NFSD_DEBUG(4, "fnd one\n");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806052041.w55Kf6bj096747>