Date: Thu, 19 May 2016 00:11:18 -0400 From: Randy Westlund <rwestlun@gmail.com> To: freebsd-hackers@freebsd.org Subject: What changes are welcome? Message-ID: <20160519041118.GE19887@gmail.com>
next in thread | raw e-mail | index | archive | help
--IU5/I01NYhRvwH70 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I'd like to start contributing to the base system, but I need clarification on what sort of changes would be welcome. I thought I'd start on simple compiler warnings. The top code in /contrib/top, for example uses K&R-style function definitions and implicit return types that spews -Wimplicit-int and -Wreturn-type warnings. While I'm silencing those, is it appropriate for me to make the file follow style(9)? Once I have a diff, should I just upload it to bugzilla, or is it preferable to put it on phabricator and then link to it from bugzilla? Randy --IU5/I01NYhRvwH70 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXPTzmAAoJEGaweXjzNsmpj3UH/3DF9qmAFPVKJZxe0D+Fmq3B C2nIClbfkFkekVOBuDzVbpMIhzQ5LyFiOEffLMS43sJvBpKvNQ9B3q/c3rXzs3dj GgcuiVr6IxoV9SuxgGQiVIagdOLGXFfsprijvCPkMzVThP+jaT3o5OgH+Uq//AXf zNvK2FYYNgT2Ne8J4XwYUP89UbMEKeN5Ft5iA0+1q3U/165pLo/wQBHUz8bOvPkx 2PzLjjyMG3zzkmqr7tpmHy0gNYEZx1E7e1gZYqy4JnkOEoDgTOetrTlPqidndbZP Jx/GmyctDtYiWLmxtRr5y73nNNdqG21SJVU51N3Iuot7vgXlgKS57JAWlY4XdWc= =ct/z -----END PGP SIGNATURE----- --IU5/I01NYhRvwH70--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160519041118.GE19887>