Date: Tue, 14 Dec 2004 17:19:10 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 vm_machdep.c Message-ID: <200412141719.10701.jhb@FreeBSD.org> In-Reply-To: <41BF48D4.8080305@root.org> References: <200411300618.iAU6IkQX065609@repoman.freebsd.org> <200412141333.06213.jhb@FreeBSD.org> <41BF48D4.8080305@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 14 December 2004 03:11 pm, Nate Lawson wrote: > John Baldwin wrote: > > On Tuesday 30 November 2004 01:18 am, Nate Lawson wrote: > >>njl 2004-11-30 06:18:46 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/i386/i386 vm_machdep.c > >> Log: > >> MFamd64: Remove the cpu_reset_proxy cruft now that we run boot() on > >> cpu 0. Also, restructure cpu_reset to be cleaner (no functional > >> change.) > > > > FYI, this breaks the 'reset' command from ddb if you panic on a cpu other > > than the BSP. boot() isn't the only function that calls cpu_reset(), so > > perhaps this should be reverted (same for amd64) > > No, I think we should move forward instead of backward. Entering the > debugger should happen on the BSP and possibly other cpus need to be > stopped by panic(). Erm, well, that's not always easy since sometimes when you panic you can't talk to the other CPUs for whatever reason. Putting back the proxy reset doesn't hurt for now but does restore functionality in at least some cases. I'd rather have that then certain hard panics not get into ddb because we couldn't get onto the BSP to run ddb. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200412141719.10701.jhb>