Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Jun 2009 14:13:06 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        cvs-src-old@freebsd.org
Subject:   cvs commit: src/sys/rpc svc.c svc.h svc_vc.c
Message-ID:  <200906041413.n54EDDuM086766@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help

rmacklem    2009-06-04 14:13:06 UTC

  FreeBSD src repository

  Modified files:
    sys/rpc              svc.c svc.h svc_vc.c 
  Log:
  SVN rev 193436 on 2009-06-04 14:13:06Z by rmacklem
  
  Fix two races in the server side krpc w.r.t upcalls:
    Add a flag so that soupcall_clear() is only called once to cancel
    an upcall.
    Move the test for xprt_registered in the upcall down to after the
    mtx_lock() of the pool mutex, to catch the case where it is
    unregistered while the upcall is waiting for the mutex.
  Also, move the mtx_destroy() of the pool mutex to after SVC_RELEASE(),
  so that it isn't destroyed before the upcalls are disabled.
  
  Reviewed by:    dfr, jhb
  Tested by:      pho
  Approved by:    kib (mentor)
  
  Revision  Changes    Path
  1.4       +5 -4      src/sys/rpc/svc.c
  1.4       +1 -0      src/sys/rpc/svc.h
  1.7       +14 -3     src/sys/rpc/svc_vc.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906041413.n54EDDuM086766>