Date: Tue, 27 Jun 2000 13:10:27 -0700 (PDT) From: Doug Barton <Doug@gorean.org> To: Matthew Jacob <mjacob@feral.com> Cc: Warner Losh <imp@village.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/isp isp.c Message-ID: <Pine.BSF.4.21.0006271307560.26405-100000@dt052n3e.san.rr.com> In-Reply-To: <Pine.BSF.4.05.10006271251410.25569-100000@semuta.feral.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Jun 2000, Matthew Jacob wrote:
>
> Thanks!
>
> I hope it wasn't *too* big- I wanted to store all the info somewhere.
Heck no. If anything, it would be nice if more people included
more detail. Someone (I think it was Peter) recommended that commit
messages should go into detail about _why_ something was done, and touch
lightly on what was done since that info is available in the diff. I'm all
in favor of anything that keeps me from having to go look the diff up,
personally.
Doug
> On Tue, 27 Jun 2000, Warner Losh wrote:
>
> > In message <200006271944.MAA53998@freefall.freebsd.org> Matt Jacob writes:
> > : Fix usage of DELAY (SYS_DELAY is the platform independent local
> > : define). Fix stupidity wrt checking whether we've gone to
> > : LOOP_PDB_RCVD loopstate- it's okay to be greater than this state.
> > : D'oh! Protect calls to isp_pdb_sync and isp_fclink_state with IS_FC
> > : macros.
> >
> > Excellent commit message.
> >
> > Warner
> >
>
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe cvs-all" in the body of the message
>
--
"Live free or die"
- State motto of my ancestral homeland, New Hampshire
Do YOU Yahoo!?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0006271307560.26405-100000>