Date: Tue, 15 Oct 2002 22:17:24 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Nate Lawson <nate@root.org> Cc: current@freebsd.org Subject: Re: GEOM/fdisk/USB drive problem Message-ID: <38906.1034713044@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 15 Oct 2002 12:53:25 PDT." <Pine.BSF.4.21.0210151251250.37181-200000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.21.0210151251250.37181-200000@root.org>, Nate Lawson wri tes: >> I could agree to make g_dev_ioctl fail the ioctl with some errno >> if they came back as zero, but not substituting another value. > >The attached patch makes everything work fine for my drive (64 MB USB >flash). Apart from the choice of EINVAL, this would be OK with me, I would probably say ENOENT instead. EINVAL generally means "you gave a wrong parameter to a syscall", ENOENT is more of a "Looked, found nothing" kind of error. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?38906.1034713044>