Date: Mon, 18 Apr 2022 16:20:07 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 60c952d47249 - stable/13 - tty: Remove an incorrect assertion from ttyinq_line_iterate() Message-ID: <202204181620.23IGK7Ag061525@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=60c952d4724974b877b2ec02784e22b74dab8809 commit 60c952d4724974b877b2ec02784e22b74dab8809 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2022-04-12 21:30:04 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2022-04-18 16:19:57 +0000 tty: Remove an incorrect assertion from ttyinq_line_iterate() We may legitimately have tib == NULL if we're at the very end of the queue. PR: 215373 Reported by: pho Sponsored by: The FreeBSD Foundation (cherry picked from commit d769609620931a62ebacbd4f1f5fd048c7e3d7c0) --- sys/kern/tty_inq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/kern/tty_inq.c b/sys/kern/tty_inq.c index bd26211735d2..069da33ab26a 100644 --- a/sys/kern/tty_inq.c +++ b/sys/kern/tty_inq.c @@ -464,7 +464,6 @@ ttyinq_line_iterate(struct ttyinq *ti, /* Last byte iterated - go to the next block. */ if (boff == TTYINQ_DATASIZE - 1) tib = tib->tib_next; - MPASS(tib != NULL); } }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204181620.23IGK7Ag061525>